fix(agent): match channel_id api argument for set_status and set_suggested_prompts#1446
Open
fix(agent): match channel_id api argument for set_status and set_suggested_prompts#1446
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 226 226
Lines 7205 7205
=======================================
Hits 6533 6533
Misses 672 672 ☔ View full report in Codecov by Sentry. |
mwbrooks
approved these changes
Feb 19, 2026
Member
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thanks for the detailed eye @zimeg!
👍🏻 I agree with your approach - consistency is important. If we're naming the helper methods similar to the original method, then we should keep the arguments consistent. Plus _id is just better 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows #1441 and #1442 with updates to
channel_idto match the API arguments for these methods:I forget if this was meant to match the chat_stream arguments, which is
channelstill, but matching the API arguments might make references most clear I think!Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.