-
Notifications
You must be signed in to change notification settings - Fork 678
docs: updates reference docs to match source #2469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updates reference docs to match source #2469
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2469 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 40 40
Lines 11240 11240
Branches 713 713
=======================================
Hits 10464 10464
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukegalbraithrussell Kind appreciation for these updates! Let's merge this when the time is right, but also I'm wondering if we can automate this somehow 📚 ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted files seem weird to me 🤔 If these are generated changes it might be worth ensuring your local branch is up to date with main and reinstalling all the dependencies before regenerating
| - [EntityActionButton](interfaces/EntityActionButton.md) | ||
| - [EntityArrayItemField](interfaces/EntityArrayItemField.md) | ||
| - [EntityAttributes](interfaces/EntityAttributes.md) | ||
| - [EntityCustomField](interfaces/EntityCustomField.md) | ||
| - [EntityEditSupport](interfaces/EntityEditSupport.md) | ||
| - [EntityFullSizePreview](interfaces/EntityFullSizePreview.md) | ||
| - [EntityIconField](interfaces/EntityIconField.md) | ||
| - [EntityImageField](interfaces/EntityImageField.md) | ||
| - [EntityMetadata](interfaces/EntityMetadata.md) | ||
| - [EntityRefField](interfaces/EntityRefField.md) | ||
| - [EntityStringField](interfaces/EntityStringField.md) | ||
| - [EntityTimestampField](interfaces/EntityTimestampField.md) | ||
| - [EntityTypedField](interfaces/EntityTypedField.md) | ||
| - [EntityUserField](interfaces/EntityUserField.md) | ||
| - [EntityUserIDField](interfaces/EntityUserIDField.md) | ||
| - [ExternalRef](interfaces/ExternalRef.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why these might be getting removed even though they are still in the types package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's because they're already in the types package:
This is the web-api package, so these are currently duplicates. I guess these used to be in web-api
Summary
Some reference docs weren't updated. This catches them all up
Requirements (place an
xin each[ ])