Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jan 22, 2026

Summary

This PR removes the icon_url from the url source block element to match the expected API and also updates an internal chat_stream variable for maintenance ongoing.

Testing

Build these changes and stream a message with this app:

$ slack create slack-samples/bolt-python-assistant-template --branch feat-ai-apps-thinking-steps

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.models (UI component builders)
  • /docs (Documents)
  • tests/integration_tests (Automated tests for this library)

Notes

No update was made for an append without either "chunks" or "markdown_text" following discussion of #1809. With logging set to "debug" we might find an alright hint that the buffer is unchanged:

...
DEBUG:slack_sdk.web.base_client:ChatStream appended to buffer: {"buffer_length": 0, "buffer_size": 256, "channel": "D0A86GYHLG5", "recipient_team_id": "T02A074M3U3", "recipient_user_id": "U04051AF9NJ", "thread_ts": "1769060200.942659"}
DEBUG:slack_sdk.web.base_client:ChatStream appended to buffer: {"buffer_length": 0, "buffer_size": 256, "channel": "D0A86GYHLG5", "recipient_team_id": "T02A074M3U3", "recipient_user_id": "U04051AF9NJ", "thread_ts": "1769060200.942659"}
DEBUG:slack_sdk.web.base_client:ChatStream appended to buffer: {"buffer_length": 0, "buffer_size": 256, "channel": "D0A86GYHLG5", "recipient_team_id": "T02A074M3U3", "recipient_user_id": "U04051AF9NJ", "thread_ts": "1769060200.942659"}
...

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimeg zimeg requested review from mwbrooks and srtaalej January 22, 2026 05:48
@zimeg zimeg self-assigned this Jan 22, 2026
@zimeg zimeg requested a review from a team as a code owner January 22, 2026 05:48
@zimeg zimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch web-client Version: 3x labels Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat-ai-apps-thinking-steps@610de5b). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat-ai-apps-thinking-steps    #1822   +/-   ##
==============================================================
  Coverage                               ?   83.96%           
==============================================================
  Files                                  ?      116           
  Lines                                  ?    13221           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    11101           
  Misses                                 ?     2120           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg zimeg changed the title fix: remove icon_url from url source block element and update chat stream variable fix: remove icon_url from url source block element and plan_id from plan block and update chat stream variable Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants