This repository was archived by the owner on Nov 12, 2025. It is now read-only.
Draft
Conversation
|
Ian Hoffman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow registering custom input types. This seems really useful from a security standpoint: when coercing input to a Hack type, the GraphQL type itself can verify that the viewer has access to the resource using global context.
I haven't done any work to make defining custom types ergonomic. You have to subclass
NamedTypeand then useTNamedInputTypeandTNonNullableType. We could definitely make this nicer.I'm also not sure this works as-is with clients. For example,
ChannelIDis a new scalar type which takes a string and outputs a Channel object. Will clients understand that when they seeChannelID, they should provide a string?