Skip to content

Change color type to use f32 values internally #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 12, 2025
Merged

Change color type to use f32 values internally #9820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0887cdd
Change Color type to be f32 internally but no other changes
expenses Nov 10, 2025
6d8e1f7
Add missing clamp
expenses Nov 10, 2025
41b8edd
Add round function as we're not on MSRV 1.90+
expenses Nov 10, 2025
ca566a6
Prepare for being able to switch between u8s and f32s
expenses Nov 10, 2025
f9e1511
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 10, 2025
b107901
Fix Display impl
expenses Nov 10, 2025
92217e0
Add feature flag for 8-bit color values. Name to be bikeshed
expenses Nov 10, 2025
23673c4
Fix brighter-darker test
expenses Nov 10, 2025
bb9aa3d
Update test screenshot
expenses Nov 10, 2025
2d7f940
Remove unused Float trait import
expenses Nov 10, 2025
aad761e
Add cfg thing for not(cbindgen)
expenses Nov 10, 2025
d43ab94
Change Channel to float in cbindgen
expenses Nov 11, 2025
4646821
Change the cpp color type for uint8_t for now
expenses Nov 11, 2025
b3760e9
Opt cpp into 8-bit-color
expenses Nov 11, 2025
0d63266
Switch feature around
expenses Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/cpp/cbindgen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ fn default_config() -> cbindgen::Config {
// therefore it is ok to reinterpret_cast
("MenuEntryModel".into(), "std::shared_ptr<slint::Model<MenuEntry>>".into()),
("Coord".into(), "float".into()),
("Channel".into(), "uint8_t".into()),
Copy link
Member

@tronical tronical Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Contributor Author

@expenses expenses Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, otherwise it tries to use an undefined Channel type

]
.iter()
.cloned()
Expand Down Expand Up @@ -397,6 +398,7 @@ fn gen_corelib(
"MenuEntryModel",
"MenuEntryArg",
"Coord",
"Channel",
"LogicalRect",
"LogicalPoint",
"LogicalPosition",
Expand Down
1 change: 1 addition & 0 deletions internal/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ unstable-wgpu-27 = ["dep:wgpu-27"]

tr = ["dep:tr"]

32-bit-color = []
default = ["std", "unicode"]

shared-parley = ["shared-fontique", "dep:parley", "dep:skrifa"]
Expand Down
Loading
Loading