Skip to content

test: feat/build-push-docker-tag-check #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikburt wants to merge 1 commit into from
Closed

test: feat/build-push-docker-tag-check #1527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/reusable-docker-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,13 @@
required: false
type: string
default: "false"
allow-overwrites:
description: |
Whether to allow overwriting existing Docker images with the same tag in AWS ECR.
Default is true (for backwards compatibility).
required: false
type: string
default: "true"

outputs:
docker-image-sha-digest-amd64:
Expand Down Expand Up @@ -507,7 +514,7 @@
environment:
name: ${{ inputs.environment }}
# http://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments
deployment: false

Check failure on line 517 in .github/workflows/reusable-docker-build-publish.yml

View workflow job for this annotation

GitHub Actions / ci-lint-misc 

[actionlint] reported by reviewdog 🐶
unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]

Raw Output:
e:.github/workflows/reusable-docker-build-publish.yml:517:7: unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]
runs-on: ${{ matrix.runner }}
timeout-minutes: ${{ inputs.timeout }}
strategy:
Expand Down Expand Up @@ -638,7 +645,7 @@

- name: Docker image build
id: build
uses: smartcontractkit/.github/actions/build-push-docker@build-push-docker/v1
uses: smartcontractkit/.github/actions/build-push-docker@feat/build-push-docker-tag-check # testing
with:
platform: ${{ format('linux/{0}', matrix.arch) }}
docker-registry-url: >-
Expand All @@ -664,6 +671,7 @@
aws-role-arn: ${{ secrets.AWS_ROLE_PUBLISH_ARN }}
aws-region: ${{ inputs.aws-region-ecr }}
github-token: ${{ secrets.GITHUB_TOKEN_DOCKER_BUILD_OVERRIDE || steps.token.outputs.access-token || '' }}
allow-overwrites: ${{ inputs.allow-overwrites }}

docker-manifest:
name: docker-manifest
Expand All @@ -672,7 +680,7 @@
environment:
name: ${{ inputs.environment }}
# http://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments
deployment: false

Check failure on line 683 in .github/workflows/reusable-docker-build-publish.yml

View workflow job for this annotation

GitHub Actions / ci-lint-misc 

[actionlint] reported by reviewdog 🐶
unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]

Raw Output:
e:.github/workflows/reusable-docker-build-publish.yml:683:7: unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]
runs-on: ubuntu-24.04
timeout-minutes: 5
outputs:
Expand Down
10 changes: 9 additions & 1 deletion workflows/reusable-docker-build-publish/reusable-docker-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,13 @@ on:
required: false
type: string
default: "false"
allow-overwrites:
description: |
Whether to allow overwriting existing Docker images with the same tag in AWS ECR.
Default is true (for backwards compatibility).
required: false
type: string
default: "true"

outputs:
docker-image-sha-digest-amd64:
Expand Down Expand Up @@ -634,7 +641,7 @@ jobs:

- name: Docker image build
id: build
uses: smartcontractkit/.github/actions/build-push-docker@build-push-docker/v1
uses: smartcontractkit/.github/actions/build-push-docker@feat/build-push-docker-tag-check # testing
with:
platform: ${{ format('linux/{0}', matrix.arch) }}
docker-registry-url: >-
Expand All @@ -660,6 +667,7 @@ jobs:
aws-role-arn: ${{ secrets.AWS_ROLE_PUBLISH_ARN }}
aws-region: ${{ inputs.aws-region-ecr }}
github-token: ${{ secrets.GITHUB_TOKEN_DOCKER_BUILD_OVERRIDE || steps.token.outputs.access-token || '' }}
allow-overwrites: ${{ inputs.allow-overwrites }}

docker-manifest:
name: docker-manifest
Expand Down
Loading