Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves chain-family-specific behavior (signer key selection, fee aggregator fallback, executor transmitter key/address derivation, and message extra-args serialization) behind interfaces/registries so devenv can support additional chain families without editing central logic.
Changes:
- Extend
ImplFactorywith family-specific hooks (default signer key, fee aggregator fallback, funding/bootstrap capabilities, transmitter key + address derivation) and update EVM factory to implement them. - Refactor executor transmitter key generation/address derivation to accept injected family-specific resolvers/generators.
- Replace EVM’s hardcoded
extraArgsfamily switch with a registry-dispatched serializer.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| build/devenv/services/executor/base.go | Make transmitter key/address logic injectable via function types. |
| build/devenv/services/executor.go | Same refactor for the services-layer executor input helpers. |
| build/devenv/evm/impl.go | Dispatch extra-args serialization via a registered per-family serializer; register EVM serializer. |
| build/devenv/evm/cctp.go | Add documentation clarifying CCTP selector filtering assumptions. |
| build/devenv/evm_factory.go | Implement new ImplFactory methods for the EVM family (signer, fee aggregator, funding/bootstrap flags, transmitter key/address). |
| build/devenv/environment.go | Delegate signer/fee-aggregator defaults and executor key/address derivation to registered ImplFactory implementations. |
| build/devenv/chain_impl_factory.go | Extend ImplFactory interface and add GetAllImplFactories snapshot helper. |
| build/devenv/cciptestinterfaces/interface.go | Add a global registry for destination-family extra-args serializers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
makramkd
previously approved these changes
Apr 13, 2026
|
Code coverage report:
|
winder
reviewed
Apr 13, 2026
Comment on lines
+34
to
+64
|
|
||
| // DefaultSignerKey returns the default signer key for this chain family | ||
| // given the bootstrap keys from a verifier node. Each family selects the | ||
| // appropriate key type (e.g. EVM uses ECDSAAddress, Stellar uses EdDSA). | ||
| // Return "" if no default signer is available. | ||
| DefaultSignerKey(keys services.BootstrapKeys) string | ||
|
|
||
| // DefaultFeeAggregator returns a fee aggregator address to use as a | ||
| // fallback when topology omits one for the given chain. Each family | ||
| // extracts the deployer address in its native format from the environment. | ||
| // Return "" if no fallback is available for the given selector. | ||
| DefaultFeeAggregator(env *deployment.Environment, chainSelector uint64) string | ||
|
|
||
| // SupportsFunding reports whether this chain family supports native token | ||
| // funding of executor addresses. Families that lack on-chain transfer | ||
| // primitives in devenv (e.g. Canton) return false. | ||
| SupportsFunding() bool | ||
|
|
||
| // SupportsBootstrapExecutor reports whether executors for this family | ||
| // use the bootstrap.Run lifecycle (JD-managed with DB). Families that | ||
| // use standalone executors (legacy mode, no bootstrap) return false. | ||
| SupportsBootstrapExecutor() bool | ||
|
|
||
| // GenerateTransmitterKey generates a fresh private key for executor | ||
| // transaction signing in the native format for this chain family. | ||
| // Returns the hex-encoded private key string. | ||
| GenerateTransmitterKey() (string, error) | ||
|
|
||
| // TransmitterAddress derives the on-chain transmitter address from the | ||
| // given hex-encoded private key in the native format for this family. | ||
| TransmitterAddress(privateKeyHex string) (protocol.UnknownAddress, error) |
Collaborator
There was a problem hiding this comment.
These should probably all go in cciptestinterfaces.CCIP17Configuration
winder
approved these changes
Apr 13, 2026
makramkd
approved these changes
Apr 13, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.