fix tp devenv#1020
Merged
stackman27 merged 11 commits intomainfrom Apr 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the devenv token-transfer auto-configuration flow to correctly handle mixed EVM/Canton lanes by changing how token transfer configs are filtered and grouped before applying ConfigureTokensForTransfers.
Changes:
- Group
TokenTransferConfigs by full lane pair (local+remote pool refs) instead of only the local pool identity to avoid splitting mixed EVM/Canton lanes. - Update EVM token-transfer config generation to keep topology-based combinations while deferring datastore existence checks to per-chain/per-remote logic.
- Add additional per-remote configuration fields in EVM transfer config generation (including token ref and outbound rate limiter settings).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build/devenv/implcommon.go | Reworks grouping of token transfer configs to be lane-pair based and adds mixed-lane conflict resolution. |
| build/devenv/evm/impl.go | Adjusts token combo filtering/existence checks for mixed lanes and updates generated remote-chain config fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tt-cll
reviewed
Apr 13, 2026
| if candidate.TokenPoolRef.Type == datastore.ContractType(devenvcommon.BurnMintTokenPoolType) { | ||
| return candidate, nil | ||
| } | ||
| case chainsel.FamilyCanton: |
Contributor
There was a problem hiding this comment.
we took this offline but we shouldn't be using chain specific switches. We should fix the filtering mechanism
tt-cll
approved these changes
Apr 14, 2026
skudasov
approved these changes
Apr 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.