Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@anthropic-ai/mcpb": "^1.1.1",
"@biomejs/biome": "2.3.10",
"@modelcontextprotocol/sdk": "^1.25.3",
"@smithery/api": "^0.62.0",
"@smithery/api": "^0.64.2",
"@smithery/sdk": "^4.1.0",
"@types/inquirer": "^8.2.4",
"@types/inquirer-autocomplete-prompt": "^3.0.3",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

105 changes: 29 additions & 76 deletions src/commands/__tests__/trigger-api.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,115 +2,68 @@ import { describe, expect, test, vi } from "vitest"
import { ConnectSession } from "../mcp/api"

describe("ConnectSession trigger support", () => {
test("uses typed trigger and subscription resources", async () => {
test("uses typed trigger resources aligned with the MCP Events spec", async () => {
const listTriggers = vi.fn().mockResolvedValue([])
const getTrigger = vi.fn().mockResolvedValue({ name: "page.updated" })
const createTrigger = vi.fn().mockResolvedValue({ id: "trg_123" })
const getTriggerInstance = vi.fn().mockResolvedValue({ id: "trg_123" })
const deleteTrigger = vi.fn().mockResolvedValue({ success: true })
const listNamespaceSubscriptions = vi.fn().mockResolvedValue([])
const createNamespaceSubscription = vi.fn().mockResolvedValue({
const subscribeTrigger = vi.fn().mockResolvedValue({
id: "sub_123",
refreshBefore: "2026-05-02T12:00:00.000Z",
})
const deleteNamespaceSubscription = vi.fn().mockResolvedValue({
success: true,
})
const listConnectionSubscriptions = vi.fn().mockResolvedValue([])
const createConnectionSubscription = vi.fn().mockResolvedValue({
id: "sub_456",
})
const deleteConnectionSubscription = vi.fn().mockResolvedValue({
success: true,
})
const unsubscribeTrigger = vi.fn().mockResolvedValue({ success: true })

const session = new ConnectSession(
{
connections: {
triggers: {
list: listTriggers,
get: getTrigger,
create: createTrigger,
getInstance: getTriggerInstance,
delete: deleteTrigger,
subscribe: subscribeTrigger,
unsubscribe: unsubscribeTrigger,
},
subscriptions: {
list: listConnectionSubscriptions,
create: createConnectionSubscription,
delete: deleteConnectionSubscription,
},
},
subscriptions: {
list: listNamespaceSubscriptions,
create: createNamespaceSubscription,
delete: deleteNamespaceSubscription,
},
} as never,
"my app",
)

await session.listTriggers("notion")
await session.getTrigger("notion", "page.updated")
await session.createTrigger("notion", "page.updated", {
workspace_id: "w_123",
})
await session.getTriggerInstance("notion", "page.updated", "trg_123")
await session.deleteTrigger("notion", "page.updated", "trg_123")
await session.listSubscriptions()
await session.createSubscription("https://example.com/events")
await session.listSubscriptions("notion")
await session.createSubscription("https://example.com/notion", "notion")
await session.deleteSubscription("sub_123")
await session.deleteSubscription("sub_456", "notion")

expect(listTriggers).toHaveBeenCalledWith("notion", {
namespace: "my app",
})
expect(getTrigger).toHaveBeenCalledWith("page.updated", {
namespace: "my app",
connectionId: "notion",
})
expect(createTrigger).toHaveBeenCalledWith(
await session.subscribeTrigger(
"notion",
"page.updated",
{ workspace_id: "w_123" },
{
namespace: "my app",
connectionId: "notion",
},
{
body: { params: { workspace_id: "w_123" } },
url: "https://my-app.example.com/events",
secret: "whsec_dGVzdF9zZWNyZXRfMjRfYnl0ZXNfbWluaW11bSE=",
},
)
expect(getTriggerInstance).toHaveBeenCalledWith("trg_123", {
await session.unsubscribeTrigger(
"notion",
"page.updated",
{ workspace_id: "w_123" },
"https://my-app.example.com/events",
)

expect(listTriggers).toHaveBeenCalledWith("notion", {
namespace: "my app",
connectionId: "notion",
triggerName: "page.updated",
})
expect(deleteTrigger).toHaveBeenCalledWith("trg_123", {
expect(getTrigger).toHaveBeenCalledWith("page.updated", {
namespace: "my app",
connectionId: "notion",
triggerName: "page.updated",
})
expect(listNamespaceSubscriptions).toHaveBeenCalledWith("my app")
expect(createNamespaceSubscription).toHaveBeenCalledWith("my app", {
body: { url: "https://example.com/events" },
})
expect(listConnectionSubscriptions).toHaveBeenCalledWith("notion", {
expect(subscribeTrigger).toHaveBeenCalledWith("page.updated", {
namespace: "my app",
})
expect(createConnectionSubscription).toHaveBeenCalledWith(
"notion",
{
namespace: "my app",
},
{
body: { url: "https://example.com/notion" },
connectionId: "notion",
delivery: {
url: "https://my-app.example.com/events",
secret: "whsec_dGVzdF9zZWNyZXRfMjRfYnl0ZXNfbWluaW11bSE=",
},
)
expect(deleteNamespaceSubscription).toHaveBeenCalledWith("sub_123", {
namespace: "my app",
params: { workspace_id: "w_123" },
})
expect(deleteConnectionSubscription).toHaveBeenCalledWith("sub_456", {
expect(unsubscribeTrigger).toHaveBeenCalledWith("page.updated", {
namespace: "my app",
connectionId: "notion",
delivery: { url: "https://my-app.example.com/events" },
params: { workspace_id: "w_123" },
})
})
})
Loading
Loading