Skip to content

ci: the MRI retry budget went stale the same way JRuby's did - #293

Merged
pftg merged 1 commit into
masterfrom
ci/mri-timeout-budget
Aug 25, 2026
Merged

ci: the MRI retry budget went stale the same way JRuby's did#293
pftg merged 1 commit into
masterfrom
ci/mri-timeout-budget

Conversation

@pftg

@pftg pftg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

3.3/rails81 timed out on run 32889000873 and cancelled nine sibling cells with it. Tests were still printing dots when SIGTERM landed — slow, not hung: the same signature as the JRuby timeout #289 fixed one release ago.

#289 explicitly left MRI alone, and was right at the time

"MRI is 128s against 3 min and does not move."

Measured now on run 32770212615, the last green master run:

cell attempt
3.4/rails81 78s
4.0/rails72 89s
3.4/rails80 123s
4.0/rails80 131s
3.4/rails71 132s
3.4/rails72 134s
3.3/rails81 144s — vs a 180s cap, and the cell that timed out
4.0/edge 146s

23% headroom at the slowest, down from the ~40% the 3-minute figure was chosen for.

Fix

4 minutes puts the slowest back to ~64%, and the job cap follows so the arithmetic stays true: 1 + 4 + 4 = 9.

The comment now states the general rule outright, because this is the second time:

These numbers are measurements, not settings. A suite that grows silently erodes every budget derived from it, and the failure mode is a cell that has been passing by seconds until the day it doesn't.

Costs nothing on a green run — a ceiling, not a sleep. YAML validated.

Unblocks #290, whose only real failure was this timeout.

Summary by Sourcery

Restore sufficient CI time for MRI test matrix cells by recalibrating their retry and job timeout budgets.

Bug Fixes:

  • Increase MRI test-cell timeouts and the overall job timeout to prevent slow, still-progressing test runs from being cancelled as failures.

Enhancements:

  • Document the need to remeasure and raise both per-attempt and job timeout budgets together as test-suite duration grows.

`3.3/rails81` timed out on run 32889000873 and cancelled nine sibling cells with
it. Tests were still printing dots when SIGTERM landed -- slow, not hung, the
same signature as the JRuby timeout #289 fixed a release earlier.

#289 left the MRI number alone on the grounds that "MRI is 128s against 3 min
and does not move". That was true when written. Measured now on run 32770212615,
the last green master run:

    3.4/rails81    78s
    4.0/rails72    89s
    3.4/rails80   123s
    4.0/rails80   131s
    3.4/rails71   132s
    3.4/rails72   134s
    3.3/rails81   144s   <- against a 180s cap, and the cell that timed out
    4.0/edge      146s

23% headroom at the slowest, down from the ~40% the 3-minute figure was chosen
for. 4 minutes puts it back to ~64%, and the job cap follows so the arithmetic
stays true: 1 + 4 + 4 = 9.

The comment now says the general thing outright, because this is twice: these
numbers are MEASUREMENTS, not settings. A suite that grows silently erodes every
budget derived from it, and the failure mode is a cell that has been passing by
seconds until the day it does not.

Costs nothing on a green run -- it is a ceiling, not a sleep. YAML validated.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @pftg, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 days and 22 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 20 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ebea4e7f-9a0e-45f8-8b2b-d63246a2375f

📥 Commits

Reviewing files that changed from the base of the PR and between df78dc0 and 6e777e6.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the GitHub Actions MRI retry budget from 3/8 to 4/9 minutes after a measured 144-second cell timed out, while documenting the rationale and preserving a job cap that accommodates setup plus two attempts.

File-Level Changes

Change Details Files
Increase MRI test attempt and job timeouts to prevent slow-but-progressing cells from being cancelled.
  • Raise the MRI per-attempt timeout from 3 to 4 minutes.
  • Raise the MRI job cap from 8 to 9 minutes to preserve setup plus two-attempt budget arithmetic.
  • Retain the existing two-attempt strategy and JRuby budgets.
  • Document the measurement-driven timeout policy and the need to raise both related limits together.
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pftg
pftg merged commit 3a4c4d2 into master Aug 25, 2026
23 checks passed
@pftg
pftg deleted the ci/mri-timeout-budget branch August 25, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant