ci: the MRI retry budget went stale the same way JRuby's did - #293
Conversation
`3.3/rails81` timed out on run 32889000873 and cancelled nine sibling cells with it. Tests were still printing dots when SIGTERM landed -- slow, not hung, the same signature as the JRuby timeout #289 fixed a release earlier. #289 left the MRI number alone on the grounds that "MRI is 128s against 3 min and does not move". That was true when written. Measured now on run 32770212615, the last green master run: 3.4/rails81 78s 4.0/rails72 89s 3.4/rails80 123s 4.0/rails80 131s 3.4/rails71 132s 3.4/rails72 134s 3.3/rails81 144s <- against a 180s cap, and the cell that timed out 4.0/edge 146s 23% headroom at the slowest, down from the ~40% the 3-minute figure was chosen for. 4 minutes puts it back to ~64%, and the job cap follows so the arithmetic stays true: 1 + 4 + 4 = 9. The comment now says the general thing outright, because this is twice: these numbers are MEASUREMENTS, not settings. A suite that grows silently erodes every budget derived from it, and the failure mode is a cell that has been passing by seconds until the day it does not. Costs nothing on a green run -- it is a ceiling, not a sleep. YAML validated.
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the GitHub Actions MRI retry budget from 3/8 to 4/9 minutes after a measured 144-second cell timed out, while documenting the rationale and preserving a job cap that accommodates setup plus two attempts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
3.3/rails81timed out on run 32889000873 and cancelled nine sibling cells with it. Tests were still printing dots when SIGTERM landed — slow, not hung: the same signature as the JRuby timeout #289 fixed one release ago.#289 explicitly left MRI alone, and was right at the time
Measured now on run
32770212615, the last green master run:23% headroom at the slowest, down from the ~40% the 3-minute figure was chosen for.
Fix
4minutes puts the slowest back to ~64%, and the job cap follows so the arithmetic stays true: 1 + 4 + 4 = 9.The comment now states the general rule outright, because this is the second time:
Costs nothing on a green run — a ceiling, not a sleep. YAML validated.
Unblocks #290, whose only real failure was this timeout.
Summary by Sourcery
Restore sufficient CI time for MRI test matrix cells by recalibrating their retry and job timeout budgets.
Bug Fixes:
Enhancements: