Skip to content

ci: add CI Gate, one stable check name for branch protection (#281) - #296

Open
pftg wants to merge 1 commit into
masterfrom
ci/gate
Open

ci: add CI Gate, one stable check name for branch protection (#281)#296
pftg wants to merge 1 commit into
masterfrom
ci/gate

Conversation

@pftg

@pftg pftg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Closes the last box on #281.

Matrix cell names carry their ruby and gemfile, so a branch-protection rule that lists them silently stops requiring anything when the matrix changes shape — it just did (#295), and #249 will change it again.

CI Gate depends on the jobs instead of naming them. Branch protection requires that one check, forever.

  • skipped passes — the matrix is off on ordinary PRs by design.
  • cancelled fails — a cell killed before it reported carries no verdict.

Human step after merge: Settings → Branches → require CI Gate on master.

Summary by Sourcery

Add a stable aggregate CI check for branch protection across changing test matrices.

Enhancements:

  • Add a stable CI Gate check that aggregates required workflow jobs for reliable branch protection.

CI:

  • Make the CI Gate fail when required jobs fail or are cancelled while allowing skipped matrix jobs to pass.

Matrix cell names carry their ruby and gemfile, so a branch-protection rule
listing them silently stops requiring anything when the matrix changes shape --
it just did (#295) and #249 will change it again.

`skipped` passes: the matrix is off on ordinary PRs by design. `cancelled` does
not -- a cell killed before it reported carries no verdict.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @pftg, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 days and 20 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 16 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f2b98fa-91d8-430b-b7f2-a4527930b0fa

📥 Commits

Reviewing files that changed from the base of the PR and between 7691b5e and f96b3de.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an always-evaluated CI Gate workflow job with a stable check name that aggregates the required CI jobs, treating failures and cancellations as failures while permitting intentionally skipped matrix jobs; after merging, branch protection must be configured to require this check on master.

File-Level Changes

Change Details Files
Add a stable aggregate check that reports the combined status of all CI job groups for branch protection.
  • Create an always-evaluated CI Gate job with a fixed display name.
  • Declare dependencies on the setup, functional, matrix, and screenshot-driver jobs.
  • Fail when any dependency fails or is cancelled, while allowing skipped dependencies to pass.
.github/workflows/test.yml

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant