Skip to content

SNOW-1737942: Configurable prefetch parameters for LibSfClient (Prefetch only) #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
+9 −3
Draft

SNOW-1737942: Configurable prefetch parameters for LibSfClient (Prefetch only) #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6bdca9
change hardcoded thread number to session parameters
sfc-gh-ext-simba-jy Apr 4, 2025
93aa7b2
Merge branch 'master' into SNOW-1737942
sfc-gh-ext-simba-jy Apr 4, 2025
c1b7876
Update client.h
sfc-gh-ext-simba-jy Apr 4, 2025
b3feb6c
Update client.h
sfc-gh-ext-simba-jy Apr 4, 2025
d706d00
add logging
sfc-gh-ext-simba-jy Apr 7, 2025
78c427c
fix
sfc-gh-ext-simba-jy Apr 7, 2025
b1cedcb
Merge branch 'master' into SNOW-1737942
sfc-gh-ext-simba-jy May 5, 2025
50eb7ef
Merge branch 'master' into SNOW-1737942
sfc-gh-ext-simba-jy Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/snowflake/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ typedef struct SF_CONNECT {
sf_bool binding_threshold_overridden;
sf_bool stage_binding_disabled;
sf_bool disable_console_login;
uint8 prefetch_threads;
sf_bool client_store_temporary_credential;
} SF_CONNECT;

Expand Down
10 changes: 7 additions & 3 deletions lib/client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,9 @@ static SF_STATUS STDCALL _reset_connection_parameters(
!sf->binding_threshold_overridden) {
sf->stage_binding_threshold = snowflake_cJSON_GetUint64Value(value);
}
else if (strcmp(name->valuestring, "CLIENT_PREFETCH_THREADS") == 0) {
sf->prefetch_threads = snowflake_cJSON_GetUint64Value(value);
}
}
}
SF_STATUS ret = SF_STATUS_ERROR_GENERAL;
Expand Down Expand Up @@ -836,6 +839,7 @@ _snowflake_check_connection_parameters(SF_CONNECT *sf) {
log_debug("get_fastfail: %s", sf->get_fastfail ? "true" : "false");
log_debug("get_maxretries: %d", sf->get_maxretries);
log_debug("get_threshold: %d", sf->get_threshold);
log_debug("prefetch_threads: %d", sf->prefetch_threads);

return SF_STATUS_SUCCESS;
}
Expand Down Expand Up @@ -1084,7 +1088,7 @@ SF_CONNECT *STDCALL snowflake_init() {
_mutex_init(&sf->mutex_stage_bind);
sf->binding_stage_created = SF_BOOLEAN_FALSE;
sf->stage_binding_threshold = SF_DEFAULT_STAGE_BINDING_THRESHOLD;

sf->prefetch_threads = SF_DEFAULT_PREFETCH_THREAD;
sf->sso_token = NULL;
sf->mfa_token = NULL;
}
Expand Down Expand Up @@ -1962,8 +1966,8 @@ static sf_bool setup_result_with_json_resp(SF_STMT* sfstmt, cJSON* data)
qrmk,
chunk_headers,
chunks,
2, // thread count
4, // fetch slot
sfstmt->connection->prefetch_threads, // thread count
sfstmt->connection->prefetch_threads * 2, // fetch slot
&sfstmt->error,
sfstmt->connection->insecure_mode,
sfstmt->connection->ocsp_fail_open,
Expand Down
1 change: 1 addition & 0 deletions lib/client_int.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#define SF_DEFAULT_GET_MAX_RETRIES 5
#define SF_MAX_GET_MAX_RETRIES 100
#define SF_DEFAULT_GET_THRESHOLD 5
#define SF_DEFAULT_PREFETCH_THREAD 4

#define SESSION_URL "/session/v1/login-request"
#define QUERY_URL "/queries/v1/query-request"
Expand Down
Loading