SNOW-2252444: Incorrect Error Message Displayed During Okta Authentication #913
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e testing purpose code
sfc-gh-dstempniak
suggested changes
Aug 8, 2025
| { | ||
| CXX_LOG_WARN("sf::IAuthenticatorOKTA::authenticate::Fail to get one time token response, response body=%s.", | ||
| picojson::value(respData).serialize().c_str()); | ||
| m_errMsg = "SFAuthenticatorVerificationFailed::authenticate::Fail to get one time token response."; |
Contributor
There was a problem hiding this comment.
This hides real reason in m_idp->m_errMsg. Auth tests failed:
[2025-08-07T18:01:37.120Z] 78: [ ERROR ] --- "SFAuthenticatorVerificationFailed::authenticate::Fail to get one time token response." != "Incorrect username or password was specified."
[2025-08-07T18:01:37.120Z] 78: [ FAILED ] test_okta_wrong_credentials
and
[2025-08-07T18:01:58.084Z] 78: [ ERROR ] --- strstr(error->msg, "SAML response is invalid or matching user is not found. Contact your local system administrator and provide the error code") != NULL
[2025-08-07T18:01:58.084Z] 78: [ FAILED ] test_external_browser_wrong_credentials
| { | ||
| IAuthenticatorOKTA::authenticate(); | ||
| if ((m_connection->error).error_code == SF_STATUS_SUCCESS && (isError() || m_idp->isError())) | ||
| if (isError() || m_idp->isError()) |
Contributor
There was a problem hiding this comment.
Or maybe this hides real IDP error message?
| continue; | ||
| } | ||
| CXX_LOG_ERROR("SF::IAuthenticatorOKTA::authenticate::Failed to get the saml response. response body=%s.", picojson::value(resp).serialize().c_str()); | ||
| m_errMsg = "SFAuthenticatorVerificationFailed::authenticate::Failed to get the saml response."; |
Contributor
There was a problem hiding this comment.
Same here, m_idp->m_errMsg will be ignored if we set m_errMsg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.