Skip to content

Conversation

@sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Nov 13, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam sfc-gh-aalam changed the title Fix history Fix CTE join fix with df.alias Nov 13, 2025
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review November 18, 2025 00:59
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners November 18, 2025 00:59
self._query_params = None
self.expr_to_alias.update(self.from_.expr_to_alias)
self.df_aliased_col_name_to_real_col_name.update(
self.df_aliased_col_name_to_real_col_name = deepcopy(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepcopy is not equivalent to update.

if there is a "key" in self.df_aliased_col_name_to_real_col_name but not in self.from_.df_aliased_col_name_to_real_col_name.

the previous update will keep the "key", but deepcopy will discard the "key".

will this cause issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. However this is the __init__ method. At this point, self.df_aliased_col_name_to_real_col_name should be empty generated by Selectable init

self.df_aliased_col_name_to_real_col_name = (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants