Skip to content

Conversation

@dan-arpino
Copy link
Contributor

@dan-arpino dan-arpino commented Oct 14, 2025

Description

  • Renaming snyk_rules.md -> snyk_rules_always_apply.md
  • Adding snyk_rules_smart_apply.md
  • Having mcp script pull the snyk_rules_always_apply.md rules and apply it to the snyk_rules.mdc file (This will allow us to change it to pull from snyk_rules_smart_apply when the slider is done)

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@snyk-io
Copy link

snyk-io bot commented Oct 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@dan-arpino dan-arpino requested a review from ShawkyZ October 14, 2025 17:32
@dan-arpino dan-arpino force-pushed the feat/ag-22-create-initial-smart-apply-rule branch from 0751c65 to b96d489 Compare October 15, 2025 18:12
@dan-arpino dan-arpino marked this pull request as ready for review October 15, 2025 18:14
@dan-arpino dan-arpino requested review from a team as code owners October 15, 2025 18:14
@dan-arpino dan-arpino changed the base branch from main to feat/AG-17-create-security-level-picker October 15, 2025 18:29
@dan-arpino dan-arpino force-pushed the feat/ag-22-create-initial-smart-apply-rule branch from b96d489 to f120ee6 Compare October 15, 2025 18:30
return await fs.promises.readFile(path.join(vsCodeContext.extensionPath, 'out', 'assets', 'snyk_rules.md'), 'utf8');
return await fs.promises.readFile(
path.join(vsCodeContext.extensionPath, 'out', 'assets', 'snyk_rules_always_apply.md'),
'utf8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to differentiate between which rule to write but we can do that in the other pr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've talked to @sathvi-k about this. The selector should adjust which one we pick in this line.

@ShawkyZ ShawkyZ merged commit 941461a into feat/AG-17-create-security-level-picker Oct 15, 2025
8 checks passed
@ShawkyZ ShawkyZ deleted the feat/ag-22-create-initial-smart-apply-rule branch October 15, 2025 18:46
ShawkyZ added a commit that referenced this pull request Oct 17, 2025
* feat: AG-17 create security level picker

* fix: sendConfigChangedAnalytics should accept string and boolean since config interface has both types

* feat: [AG-22] Create Initial MCP Smart Apply Rule (#671)

* fix: separate configs for each value

* feat: modal popup upon install to configure mcp server

* feat: [AG-23] Add snyk_rules.mdc to .gitignore (#672)

* fix: crlf normalization

---------

Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>

* fix: setter for auto configre mcp server setting

* fix: update configuration for Snyk MCP server settings

- Renamed configuration key from `snyk.securityAtInception.autoConfigureMcpServer` to `snyk.securityAtInception.autoConfigureSnykMcpServer` in package.json.
- Updated related method calls and configuration retrievals in the codebase to reflect the new naming.
- Adjusted the handling of secure execution frequency settings to streamline the configuration process.

This change ensures consistency in naming conventions and improves clarity in the configuration settings for Snyk's features.

* fix: update mcp.json for trusted folder changes (#670)

* fix: send changes for trusted folders

* chore: update property name

---------

Co-authored-by: Dan Arpino <[email protected]>
Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants