feat: add onRequestClose to ModalBottomSheet by DanyKrk · Pull Request #70 · software-mansion-labs/react-native-bottom-sheet

DanyKrk · 2026-08-10T12:52:17Z

Summary

Adds an Android-only onRequestClose callback to ModalBottomSheet, following React Native Modal semantics as closely as practical.

Android system Back, committed predictive Back gestures, and complete, unmodified physical-keyboard Escape presses now emit the same close-request event. The callback only reports the request: it does not change the controlled index, select a detent, or dismiss the sheet. The consumer decides whether and how to close it.

Behavior

Emits exactly one close request for an eligible Back action or completed Escape press.
Keeps the consumer in control of the resulting state change and transition.
Consumes further Back and Escape input while a visible sheet animates closed, preventing duplicate requests until it settles.
Routes portal requests according to presentation order, with the topmost active portal owning the request while closed or unresolved portals are skipped.
Preserves host input behavior when the active presentation has no onRequestClose handler.

Inline sheets, iOS, accessibility dismiss actions, scrim taps, drag gestures, and programmatic index changes keep their existing behavior.

Implementation

Adds the typed onRequestClose prop, Fabric direct event, and native handler-presence signal.
Introduces shared Back and Escape request resolution and presentation tracking.
Coordinates portal ownership across multiple sheets, window roots, lifecycle changes, and predictive Back sequences.
Applies the same onRequestClose semantics to portal and nativeOverlay presentations.
Adds an example screen covering closing, no-op, and omitted handlers in both presentation modes.

Test coverage

Adds 64 JVM and Robolectric tests covering request decisions, Escape sequences, predictive Back, portal ordering, lifecycle transitions, overlay behavior, presentation tracking, and the JS/native event bridge.
Adds 5 Android instrumentation tests covering Escape routing through focused views and Back handling while a sheet animates closed
Adds Android test commands and contributor guidance in TESTING.md.
Runs Android unit tests and instrumentation assembly in the main check job.
Runs instrumentation tests on an API 36 emulator with hardware-keyboard input enabled.

Register Back and Escape handlers lazily when onRequestClose is first provided, then preserve their ordering by toggling eligibility instead of re-registering them. Reset registrations at structural host boundaries and add coverage for lifecycle changes, multiple sheets, predictive Back, and handler removal.

…w.callback

Supersede unfinished presses on a new initial key-down and retain short-lived tombstones so late events cannot finish the replacement.

Publish portal ownership and emission eligibility as a single state snapshot. Keep handlers stable while inactive portals yield new Back and Escape requests without retargeting input already in progress. Expand lifecycle, ownership, and controlled-dismissal coverage and update docs.

- remove redundant request-close handling updates - replace reflection-based assertions with explicit test snapshots - focus Robolectric coverage on platform-specific SDK paths - simplify bottom sheet rendering

…andler Forward Back to the host Activity and leave Escape in normal key routing when onRequestClose is omitted. Keep predictive Back actions pinned for the full gesture and ignore commits delivered after overlay teardown. Expand unit and instrumented coverage and update docs and examples.

Keep eligibility loss terminal for the current Escape sequence, even if the handler or modal state is restored before key-up. Reuse the shared dispatcher state for portal and native-overlay handling.

Keep portal and native-overlay presentations as close-input boundaries while visible close animations settle, consuming Back and Escape without emitting another onRequestClose. Unify request, consume, and pass-through transport states, stabilize predictive Back handling, and update tests, examples, and documentation.

…oundaries

- track closing presentation through a production state tracker - verify controllers through observable input routing and window flags - cover close-animation ownership with an instrumentation test

Rename request-close state, routing, lifecycle, and presentation symbols to reflect their actual responsibilities. Align the native bridge, tests, and documentation with the updated terminology.

Restore the host's current interaction state after the dialog's final window configuration so an already-open sheet does not remain invisible, unfocusable, or untouchable when moved into a native overlay. Cover the restored window flags and wait for real window focus before testing hardware Escape routing.

- focus public docs on observable onRequestClose behavior - clarify native routing comments and portal demo copy - generalize Android testing instructions

patrickmichalik · 2026-09-02T07:37:32Z

+  implementation "androidx.activity:activity:1.8.2"
+  implementation "androidx.core:core:1.8.0"


Are 1.8.2 and 1.8.0 intended as minimum compatibility floors? They’re substantially behind the latest stable releases: 1.13.0 and 1.19.0, respectively. If this is intentional, let’s document it; otherwise, it would be good to update.

patrickmichalik · 2026-09-02T08:55:59Z

@@ -0,0 +1,93 @@
+@file:Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")


This seems redundant.

patrickmichalik · 2026-09-02T08:58:51Z

@@ -0,0 +1,378 @@
+@file:Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")


The OVERRIDE_DEPRECATION suppression is needed only for NoOpInstrumentedEventDispatcher.onCatalystInstanceDestroyed (line 377). Could we keep DEPRECATION here, explain that it’s for the legacy-architecture fixture, and move the OVERRIDE_DEPRECATION suppression onto the override of the aforementioned function?

DanyKrk added 26 commits August 20, 2026 19:15

Initial implementation of onRequestClose

c100e49

fix(android): consume Back and Escape in nativeOverlay

a4d0355

test(android): add Robolectric test infrastructure

dc8f993

fix(android): resolve portal request-close owners from view tree

fb390bc

fix(android): implement portal escape handling without touching windo…

620de58

…w.callback

fix(android): route portal Escape to the topmost eligible sheet

e11ad75

fix(android): recover from orphaned Escape presses

85d05bf

Supersede unfinished presses on a new initial key-down and retain short-lived tombstones so late events cannot finish the replacement.

fix(android): resolve portal request-close ownership natively

5d4ddd6

test(android): lock in modal Escape routing semantics

e27bd2f

test(android): run Robolectric tests on JDK 17

2f66897

ci(android): add instrumented test build and emulator job

5ed28a3

refactor(android): simplify Escape request-close state machine

481ac69

refactor(android): unify native overlay Back handling

41ecb1e

refactor(android): simplify request-close handling and tests

1e014a8

- remove redundant request-close handling updates - replace reflection-based assertions with explicit test snapshots - focus Robolectric coverage on platform-specific SDK paths - simplify bottom sheet rendering

fix(android): prevent captured Escape request reactivation

68f296e

Keep eligibility loss terminal for the current Escape sequence, even if the handler or modal state is restored before key-up. Reuse the shared dispatcher state for portal and native-overlay handling.

refactor(android): clarify native overlay Escape dispatcher naming

d508705

fix(android): scope portal Back callback to presentation lifetime

d2ede33

fix(android): defer portal Escape listener until presentation

b356e58

test(android): deduplicate Escape dispatch test helpers

105b446

refactor(android): simplify portal Escape dispatch result

28116b9

fix(android): pass onRequestClose directly to native bottom sheet

0ba3288

refactor(android): restore portal element naming

4ec0487

DanyKrk force-pushed the onRequestClose branch from f1db99f to 4ec0487 Compare August 20, 2026 17:26

DanyKrk marked this pull request as draft August 20, 2026 17:31

DanyKrk changed the title ~~On request close~~ Add onRequestClose prop Aug 20, 2026

DanyKrk linked an issue Aug 20, 2026 that may be closed by this pull request

[Feature request] Add onRequestClose callback to normalize Android back and ESC key handling #65

Open

DanyKrk added 4 commits August 24, 2026 15:41

refactor(android): extract request-close controllers

6e6093f

docs: clarify Android onRequestClose input handling

3f0c18b

refactor(android): reconcile request-close controllers at lifecycle b…

ed3a643

…oundaries

refactor(android): restore default overlay soft input mode

8eebf23

DanyKrk force-pushed the onRequestClose branch from bad433c to 8eebf23 Compare August 24, 2026 13:41

DanyKrk added 22 commits August 24, 2026 16:07

fix(android): retain request-close ownership for duplicate zero detents

517cd55

test(android): simplify onRequestClose integration coverage

2846469

refactor(android): remove request-close test hooks

5f6e9c8

- track closing presentation through a production state tracker - verify controllers through observable input routing and window flags - cover close-animation ownership with an instrumentation test

test(android): move Escape coverage to request-close dispatcher tests

96b030b

test(android): cover portal Escape routing state changes

23c174b

refactor(android): clarify request-close routing terminology

070d741

Rename request-close state, routing, lifecycle, and presentation symbols to reflect their actual responsibilities. Align the native bridge, tests, and documentation with the updated terminology.

docs(android): clarify overlay request-close ownership

fc7e2fd

refactor(android): clarify request-close presentation state names

696780e

refactor(android): clarify attach layout fallback name

fcf45ff

docs(android): clarify request close listener

2dda507

refactor(android): consolidate request-close tracker transitions

de759ba

refactor(android): clarify close request state names

c27cc5c

refactor(android): inline spring completion

473daa2

docs: streamline Android close request guidance

b6b2415

- focus public docs on observable onRequestClose behavior - clarify native routing comments and portal demo copy - generalize Android testing instructions

refactor(android): share inactive request-close state

dd9a018

refactor(android): group request-close implementation

f6a2121

ci(android): align emulator image with API level

597cf71

test(android): assert observable Escape behavior

dfb581e

ci: cancel superseded check runs

8c9ce70

test(android): cover request-close bridge and Escape regression

9101a45

chore(example): remove portal request-close harness

002fc9c

DanyKrk marked this pull request as ready for review September 1, 2026 12:12

patrickmichalik reviewed Sep 2, 2026

View reviewed changes

refactor: rename onRequestClose to onCloseRequest

d3914ec

Navigation Menu

Uh oh!

feat: add onRequestClose to ModalBottomSheet - #70

feat: add onRequestClose to ModalBottomSheet#70
DanyKrk wants to merge 55 commits into
software-mansion-labs:mainfrom
DanyKrk:onRequestClose

DanyKrk commented Aug 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

patrickmichalik Sep 2, 2026

Uh oh!

patrickmichalik Sep 2, 2026

Uh oh!

patrickmichalik Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		implementation "androidx.activity:activity:1.8.2"
		implementation "androidx.core:core:1.8.0"

		@@ -0,0 +1,93 @@
		@file:Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")

		@@ -0,0 +1,378 @@
		@file:Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")

Uh oh!

Conversation

DanyKrk commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Behavior

Implementation

Test coverage

Uh oh!

Uh oh!

patrickmichalik Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

patrickmichalik Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

patrickmichalik Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DanyKrk commented Aug 10, 2026 •

edited

Loading