add: note to DataAccessException introduction.#362
Open
bsharplydian wants to merge 1 commit intosoftwareconstruction240:mainfrom
Open
add: note to DataAccessException introduction.#362bsharplydian wants to merge 1 commit intosoftwareconstruction240:mainfrom
bsharplydian wants to merge 1 commit intosoftwareconstruction240:mainfrom
Conversation
…more Exception classes could be helpful.
leesjensen
reviewed
Apr 3, 2026
|
|
||
| The starter code includes a `dataAccess.DataAccessException`. This exception should be thrown by data access methods that could fail. If a method call fails, it should throw a `DataAccessException`. For example, the `DataAccessException` is thrown if a user attempts to update a non-existent game. If you like, feel free to create subclasses of DataAccessException that represent more specific errors relating to data access. | ||
|
|
||
| > [!NOTE] |
Contributor
There was a problem hiding this comment.
Would it be helpful to give an example of why you might want to add other classes and possibly point to the exception instruction rather than the note.
We might want to enhance the exception instruction to actually give an example in the custom exception section that shows how to extend the exception class and why you would do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This indicates that adding more Exception classes could be helpful for organization, but doesn't prescribe any details.