Repository navigation
program: Return an error instead of panicking on Reallocate overflow - #381
Merged
joncinque merged 1 commit intoOct 12, 2026
Merged
Conversation
Reallocate added the record header size to the requested data length with checked_add(...).unwrap(), so a data_length close to u64::MAX made the program panic instead of returning InvalidArgument. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reallocatecomputes the new account length withsize_of::<RecordData>().checked_add(data_length).unwrap(). Adata_lengthclose tou64::MAXoverflows the addition, and the program panics (SBF program Panicked in program/src/processor.rs at 164:18) instead of returning an error. Adata_lengththat does not fit inusizealready returnsInvalidArgument.Summary of Changes
ProgramError::InvalidArgumentwhen the length addition overflows, so it matches the existingusize::try_fromerror.Reallocatewithu64::MAXand expectsInvalidArgument. Before the change it fails withProgramFailedToComplete.I used an AI assistant (Claude) while preparing this. I reproduced the issue and checked the fix and tests myself.
🤖 Generated with Claude Code