Conversation
github-actions
bot
added
the
changelog:solidus_core
| deprecate try_spree_current_user: :spree_current_user, deprecator: Spree::Deprecation | ||
| deprecate \ | ||
| try_spree_current_user: :spree_current_user, | ||
| redirect_back_or_default: 'Please use `redirect_to stored_spree_user_location_or(...)` when using solidus_auth_devise.', |
There was a problem hiding this comment.
We're losing the information when not using solidus_auth_devise, right?
There was a problem hiding this comment.
That information was bad, we wrote it (me and @cpfergus1) before having a clear picture of all the ramifications.
I think not having auth-devise in the store is really niche and probably something that required custom implementations anyway. What do you think about having an example implementation in the upgrading instructions?
There was a problem hiding this comment.
That would be great, but I'm not very familiar with it. How would it look?
Appeasing Rubocop in the process.
elia
force-pushed
the
elia/auth-deprecations
branch
from
075d6ba to
0e41bb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4854 +/- ##
==========================================
- Coverage 86.18% 86.17% -0.01%
==========================================
Files 578 578
Lines 14668 14666 -2
==========================================
- Hits 12641 12639 -2
Misses 2027 2027
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 participants
Summary
Use the
deprecaterails helper taking in method names to have a more standard message and improve the wording and suggested alternatives.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):