-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[srv6] add uA action to static srv6 SID config #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Baorong Liu <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
| "decap_dscp_mode": "uniform" | ||
| }, | ||
| } | ||
| Example for SID with uN action and SID with uA action configuration (2 SIDs configuration): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment says 2 SID uN and uA, but example has only 1 uA?
Signed-off-by: Baorong Liu <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
cscarpitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ahsalam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
doc/srv6/srv6_static_config_hld.md
Outdated
| exit | ||
| ! | ||
| locator loc2 | ||
| prefix fcbb:bbbb:21::/48 block-len 32 node-len 16 func-bits 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indentation here is not aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix it.
| "loc2|FCBB:BBBB:21:FE24::/64" : { | ||
| "action": "uA", | ||
| "interface": "Ethernet24", | ||
| "adj": "2001:db8:4:501::5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing mandatory decap_dscp_mode attr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that srv6orch complains it if decap_dscp_mode is missing, but it still create the SID entry.
why decap_dscp_mode attribute is needed for uA action? I assume if uA is configured, the SID need to be shift and forward to next node.
Signed-off-by: Baorong Liu <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
Add uA action to static srv6 SID config
related PR for sonic-bgpcfgd to handle SRv6 SID uA action:
sonic-net/sonic-buildimage#24279