Send more verification packets in packet trimming tests #21435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Nov 25, 2025
Contributor
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
The PR attached here slows down the draining time more, but it could be still not enough: https://github.com/Azure/sonic-mgmt.msft/pull/827/files.
bumping the packet count seems to be straightforward for the fix, hence approving.
@kperumalbfn @developfast , do you mind to also take a look at this PR?
kperumalbfn
reviewed
Nov 25, 2025
| DUMMY_IPV6 = "8000::2" | ||
| DUMMY_MAC = "00:11:22:33:44:55" | ||
| PACKET_COUNT = 10 | ||
| PACKET_COUNT = 100 |
kperumalbfn
approved these changes
Nov 25, 2025
r12f
added
Request for msft-202412 Branch
Request for 202511 branch
rgarofano-arista
force-pushed
the
send-more-verify-packets-th5
branch
from
699a78f to
3fd5bd6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
developfast
approved these changes
Nov 28, 2025
Contributor
|
@rgarofano-arista can you fix the PR checker failure? |
Signed-off-by: Ryan Garofano <[email protected]>
rgarofano-arista
force-pushed
the
send-more-verify-packets-th5
branch
from
3fd5bd6 to
0a58d9d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#897 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 4, 2025
) Signed-off-by: Ryan Garofano <[email protected]>
Collaborator
|
Cherry-pick PR to 202511: #21541 |
12 tasks
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
) Signed-off-by: Ryan Garofano <[email protected]>
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Dan Caugherty <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Dec 9, 2025
Signed-off-by: Ryan Garofano <[email protected]>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Dec 9, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Nishanth Sampath Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Verification for packet trimming tests was failing on th5. We found that trimming was not occurring because too many packets were leaking out of the egress queue despite the shaper being applied.
How did you do it?
By increasing the number of packets sent from 10 to 100 in the verification stage, we saw that trimming was occurring and the verification passed.
How did you verify/test it?
Verified that packet trimming tests were passing with the change.
Any platform specific information?
This issue was discovered when trying to support broadcom th5.
Supported testbed topology if it's a new test case?
Documentation