Add meter_type packets when creating blocking scheduler #21436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidm-arista
added
Request for msft-202412 Branch
Request for 202511 branch
rgarofano-arista
force-pushed
the
fix-shaper-packet-trimming
branch
from
d840c81 to
96bbcc8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Packet trimming tests rely on simulating congestion on an egress queue. For this, the tests are trying to apply a shaper that significantly slows down the amount of packets sent out of the target egress queue per second. We found that this shaper doesn't work on th5 with the current config.
How did you do it?
The solution to this is to add
"meter_type" packetswhen creating the blocking scheduler (shaper).How did you verify/test it?
Verified via
tcpdumpthat packet transmission rate was slowed down as expected on th5.Any platform specific information?
This issue was discovered when testing on th5
Supported testbed topology if it's a new test case?
Documentation