support IPv6 addresses by wrapping them in brackets if necessary. #21459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
added
the
Request for 202511 branch
roy-sror
reviewed
Dec 4, 2025
tests/gnmi/grpc_utils.py
Outdated
| """ | ||
| # Get DUT gRPC server address and port | ||
| ip = duthost.mgmt_ip | ||
| if ":" in duthost.mgmt_ip and not duthost.mgmt_ip.startswith('['): |
Contributor
There was a problem hiding this comment.
Xixue, this does not seem like a python way to make this operation. Also, the motivation of this change is unclear
Contributor
Author
There was a problem hiding this comment.
Hi @roy-sror , I've updated the motivation in the description, i.e. this is to fix the failure on ipv6 mgmt port setups. Also updated the code change per your suggestion
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Xixue Jia <[email protected]>
… wrapping them in brackets when necessary Signed-off-by: Xixue Jia <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: support IPv6 addresses by wrapping them in brackets if necessary.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
regression failure on ipv6 only mgmt ip on dut was introduced by CR #21303. This PR is to address the test failure of test_gnoi_system_time on dut with ipv6 mgmt ip only
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation