fix(context-drop): audio for drop-video-clip + move Ctrl-C/Ctrl-R hotkeys off terminal keys#1890
Merged
Merged
Conversation
…f terminal keys drop-video-clip (added in #1859) recorded silent video: the capture server ran `screencapture -v -x` with no audio flag. Add `-g` so the clip captures the default audio input. The source follows System Settings > Sound > Input: the mic for narration/room audio, or BlackHole (with output routed there) for system/app audio. `?audio=off` disables sound; `?device=<id>` pins a specific input via `-G<id>`. Also move the two global hotkeys that shadowed terminal keys: - drop_context: Ctrl-C -> Ctrl-Shift-C (was intercepting SIGINT/cancel) - drop_video_clip: Ctrl-R -> Ctrl-Shift-R (was intercepting reverse-i-search) Global hotkeys match the exact modifier mask, so plain Ctrl-C / Ctrl-R still reach the terminal; only the shifted variants trigger Sutando. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… label Addresses review of #1890: the drop-video-clip start notification read "Recording screen - press Ctrl-R again to stop", which (a) didn't disclose that mic audio is now captured and (b) still referenced Ctrl-R after the hotkey moved to Ctrl-Shift-R. Update to "Recording screen + mic - press Ctrl-Shift-R again to stop". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
@cla-assistant check |
liususan091219
added a commit
that referenced
this pull request
Jul 2, 2026
Follow-up to #1890 (owner request): while drop-video-clip records, the menu row reads (red dot) Drop Video Clip - recording... and reverts on stop, using the same leading-marker convention as the Mode rows. Hooks the existing isRecordingVideo flips in dropVideoClip. swiftc build verified; deployed and owner-verified live. Co-Authored-By: Maddy (Claude Opus 4.8) <noreply@anthropic.com>
liususan091219
added a commit
that referenced
this pull request
Jul 2, 2026
#1900) Follow-up to #1890 (owner request): while drop-video-clip records, the menu row reads (red dot) Drop Video Clip - recording... and reverts on stop, using the same leading-marker convention as the Mode rows. Hooks the existing isRecordingVideo flips in dropVideoClip. swiftc build verified; deployed and owner-verified live. Co-authored-by: Maddy (Claude Opus 4.8) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two small UX fixes to the drop-video-clip feature added in #1859.
1. Audio in the recorded clip
The capture server ran
screencapture -v -xwith no audio flag, so dropped clips were silent. Add-g, which records the default audio input — the source follows System Settings > Sound > Input:New query params on
/capture-video?action=start:?audio=off— record without sound (previous behavior)?device=<id>— pin a specific input via-G<id>Default (no params) now captures the default input, so the Swift caller needs no change.
2. Hotkeys off terminal-reserved keys
Two global hotkeys shadowed terminal keys and were intercepting them system-wide:
drop_context:Ctrl-C→Ctrl-Shift-C(was eating SIGINT / cancel)drop_video_clip:Ctrl-R→Ctrl-Shift-R(was eating reverse-i-search)Global hotkeys match the exact modifier mask, so plain
Ctrl-C/Ctrl-Rreach the terminal again; only the shifted variants trigger Sutando.Ctrl-S/Ctrl-V/Ctrl-Munchanged.Test
Verified end-to-end on macOS: recorded a 2s clip through
/capture-video;ffprobeconfirms both an h264 video stream and an aac stereo audio track. Screen Recording permission unaffected.🤖 Generated with Claude Code