docs: remove stale ⌃C-family hotkey assertions from comments (closes #1925)#1958
Open
john-the-dev wants to merge 1 commit into
Open
docs: remove stale ⌃C-family hotkey assertions from comments (closes #1925)#1958john-the-dev wants to merge 1 commit into
john-the-dev wants to merge 1 commit into
Conversation
…onichi#1925) The ⌃C/⌃V/⌃M defaults were retired when the Electron Sutando.app switched to a configurable hotkey contract published in state/hotkeys.json (sonichi#1920/sonichi#1924). Several comments/docs still asserted the old ⌃C binding, misleading operators debugging hotkey issues (issue sonichi#1925: "spent a session chasing dead ⌃C bindings"). Changes (comments/docs only — no behavior change): - src/Sutando/main.swift:13 — replace stale defaults list with pointer to hotkeys.json - skills/context-drop/SKILL.md — "⌃C hotkey" → "configurable via state/hotkeys.json" - skills/context-drop/Sources/ax-read/main.swift — same in two code comments - src/startup.sh — five occurrences: section header, install messages, and startup echo Leaves health-check.py:1358 untouched (PR sonichi#1924 already targets that line). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QB3qZQrwponfum2JFNvHeh
Contributor
Coverage Gate✅ No Python changes — nothing to gate (bar: 95% on changed lines). |
qingyun-wu
approved these changes
Jul 7, 2026
qingyun-wu
left a comment
qingyun-wu
left a comment
Collaborator
There was a problem hiding this comment.
Approving — comment/doc sweep matching the #1920 hotkeys.json contract; no behavior surface, CI green.
Collaborator
|
Automated review:
|
Collaborator
|
Automated mergeability review (2026-07-09) Signal: NOT MERGEABLE Current blocker(s):
This is a conservative backlog triage signal. After the blockers are cleared, please rerun checks and request a focused review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sweeps the comment/doc references to old ⌃C/⌃V/⌃M hotkeys that were retired when the Electron Sutando.app switched to a configurable contract published in
state/hotkeys.json(#1920/#1924).No behavior change — comments and docs only.
Files changed:
src/Sutando/main.swift:13— old "Defaults: drop_context=⌃C..." list → pointer to hotkeys.jsonskills/context-drop/SKILL.md— "Sutando.app's ⌃C hotkey" → "action (hotkey configurable via state/hotkeys.json)"skills/context-drop/Sources/ax-read/main.swift— two comment references to "⌃C drops"src/startup.sh— five occurrences: section comment, install message, inline comment, startup echoLeft alone:
src/health-check.py:1358— PR fix(health-check): derive sutando-app hotkey detail from published state/hotkeys.json #1924 (open) already targets that exact line; touching it here would create a merge conflict.src/web-client.ts:836— references ⌃V/⌃M in the web client event loop, which still registers those hotkeys on the browser side; accurate.src/Sutando/main.swift:1118-1119— code comment documenting why ⌃C/⌃R are avoided in favor of ⌃⇧C/⌃⇧R; these are load-bearing design notes, not stale assertions.Closes #1925.
Test plan
grep -rn '⌃C\|⌃V\|⌃M' src/ skills/context-drop/— only the intentional code-level references remain (web-client.ts event loop, main.swift avoid-⌃C rationale, main.swift recording toggle)🤖 Generated with Claude Code
https://claude.ai/code/session_01QB3qZQrwponfum2JFNvHeh