[FEAT/#1633]SP3 앰플리튜드 개선 -솝탬프 - #1637
Merged
Merged
Conversation
seungjunGong
approved these changes
Jul 22, 2026
seungjunGong
left a comment
seungjunGong
left a comment
Member
There was a problem hiding this comment.
고생하셨습니다 ~ 리뷰남긴것만 확인해주시고 머지해도 좋을거 같아요!
Comment on lines
+70
to
+72
| LaunchedEffect(Unit) { | ||
| tracker.trackViewType(SoptampAnalyticsEvent.CLICK_SOPTAMP, viewType) | ||
| } |
Member
There was a problem hiding this comment.
p1: 여기 click_soptamp 인데 화면 진입시, 찍는 이유가 있을까요?
만일 딥링크와 같은 경우를 대응하기 위함이라면 네이밍을 view_soptamp 로 바꾸는 것도 좋을거 같습니다
Member
Author
There was a problem hiding this comment.
문서에는 있다고 나와있는데, code 내부에 찾아보니 click_soptamp 가 안심어져있어서 화면진입으로 설정해놓았었는데 view_soptamp로 변경하겠습니다!
Comment on lines
+123
to
+124
| if(isCurrent) { tracker.trackViewType(SoptampAnalyticsEvent.CLICK_PARTRANKING_MYRANKING, viewType)} | ||
| else tracker.trackViewType(SoptampAnalyticsEvent.CLICK_ALLRAKING_MYRANKING, viewType) |
Member
There was a problem hiding this comment.
p1: isCurrent 값이 true 이면 위에 view 쪽을 정의한것과 같이 AllRANKING 을 false 이면 PARTRANKING 으로 되어야할거 같습니다!
| CLICK_FEED_MISSION(EventType.CLICK, "feed_mission"), | ||
| VIEW_ALLRANKING(EventType.VIEW, "allranking"), | ||
| VIEW_PARTRANKING(EventType.VIEW, "partranking"), | ||
| CLICK_ALLRAKING_MYRANKING(EventType.CLICK, "allranking_myranking"), |
Member
There was a problem hiding this comment.
p2: 오타 있습니다!
Suggested change
| CLICK_ALLRAKING_MYRANKING(EventType.CLICK, "allranking_myranking"), | |
| CLICK_ALLRANKING_MYRANKING(EventType.CLICK, "allranking_myranking"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢