Skip to content

[Mod/#1639] 마이페이지 QA - #1644

Merged
seungjunGong merged 5 commits into
developfrom
mod/#1639-mypage-qa
Jul 30, 2026
Merged

[Mod/#1639] 마이페이지 QA#1644
seungjunGong merged 5 commits into
developfrom
mod/#1639-mypage-qa

Conversation

@sonms

@sonms sonms commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related issue 🛠

Work Description ✏️

  • 플레이그라운드 홈 연결
  • 콕찌르기 친구 화면 뒤로가기 버그 수정
  • 솝탬트 섹션 레이스 컨디션 수정 및 조건 수정
  • edge to edge 수정
  • **중요: ** 솝마디 삭제

Screenshot 📸

Uncompleted Tasks 😅

  • Task1

To Reviewers 📢

솝마디가 삭제 되었습니다.. 솝흐흑..

@sonms
sonms requested a review from a team as a code owner July 29, 2026 13:10
@sonms sonms self-assigned this Jul 29, 2026
seungjunGong
seungjunGong approved these changes Jul 29, 2026
View reviewed changes

@seungjunGong seungjunGong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status bar color까지 수정 감사합니다. 고생하셨어요..!
리뷰남긴 부분만 확인해주시면 감사하겠습니다~

Comment thread feature/main/src/main/java/org/sopt/official/feature/main/MainScreen.kt Outdated
Comment on lines 186 to 187

@seungjunGong seungjunGong Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: 여기 지금 수정한 부분은 아니긴 한데, 현재는 friendType 존재 여부만 사용되고 있어요. 처리 후 isPokeFriendList를 false로 내려도 friendType extra가 남아 있으면 조건이 계속 true가 될 수 있어서, 의도에 맞게 flag 기준으로 정리해두면 좋을 것 같아요.

@sonms sonms Jul 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 그러면 intent?.hasExtra("friendType") == true 을 제거하는 것으로 가는게 맞을 거 같아요
애초에 트리거 조건도 아니고 실제 세팅하는 곳인 NavigatorProviderIntent 에서 이미 넘겨주는 값이라 지워도 동일한 역할을 하여 제거하였습니다!

Comment thread feature/main/src/main/java/org/sopt/official/feature/main/MainScreen.kt Outdated

@seungjunGong seungjunGong Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: 여기도 수정한 부분이 아니긴 한데 솝탬프 딥링크 아니라 여기 isAppjamtampDeepLink 로 수정 해야할거 같습니다..!

@sonms sonms Jul 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 몰.랐.어 바로 수정했습니다!

Comment thread feature/home/src/main/java/org/sopt/official/feature/home/HomeRoute.kt Outdated
Comment on lines +256 to +262
color = colors.onSurface400,
modifier = Modifier
.fillMaxWidth()
.noRippleClickable(onClick = homeShortcutNavigation::navigateToPlaygroundHome)

@seungjunGong seungjunGong Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

요기 해당 이미지 처럼 우측에 ">" 아이콘을 8.dp padding 넣고 문구 컬러도 white 로 변경되어야합니다! 해당 영역으로 click event 처리도 해주시면 감사하겠습니다~

@sonms sonms Jul 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 확인했습니다! 수정 후 해당 영역에 클릭 이벤트 넣었습니다~

@seungjunGong
seungjunGong merged commit e06689d into develop Jul 30, 2026
1 check passed
@seungjunGong
seungjunGong deleted the mod/#1639-mypage-qa branch July 30, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seungjunGong seungjunGong seungjunGong approved these changes

Assignees

@sonms sonms

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MOD] 마이페이지 QA

2 participants

@sonms @seungjunGong