chore(ci): harden CI + roadmap for fearless-utils hygiene by WRRicht3r · Pull Request #1297 · soramitsu/fearless-iOS

WRRicht3r · 2025-09-24T15:32:22Z

Notes: references:
- shared-features-spm pin 6d6cb16
- web3-swift dedupe 7.7.7
- optional Google keys injection
- FearlessKeys gated by INCLUDE_FEARLESS_KEYS

…already metatype - Replace self.addressFactory = type(of: addressFactory) back to direct assignment in targeted files Signed-off-by: William Richter <richter@soramitsu.co.jp>

- If param is AddressFactory.Type, keep direct assignment - Else assign metatype with type(of:) Signed-off-by: William Richter <richter@soramitsu.co.jp>

- Normalize property to AddressFactory.Type (dedupe .Type.Type) - Replace self.addressFactory = addressFactory with AddressFactory.self Signed-off-by: William Richter <richter@soramitsu.co.jp>

…essFactory.self - Line-anchored and inline pattern to catch spacing/comments variants in targeted files Signed-off-by: William Richter <richter@soramitsu.co.jp>

…den assignment rewrite - Collapse any AddressFactory.Type.Type -> AddressFactory.Type - Aggressive replacement of self.addressFactory = addressFactory (spacing/comments) to AddressFactory.self Signed-off-by: William Richter <richter@soramitsu.co.jp>

…et files Signed-off-by: William Richter <richter@soramitsu.co.jp>

- Force property and init param to AddressFactory.Type - Normalize assignment to use param metatype - Flatten any AddressFactory.Type.Type to AddressFactory.Type Signed-off-by: William Richter <richter@soramitsu.co.jp>

Add shell guard to Modules Mock and Common Mock phases to skip when Pods/Cuckoo/run is missing. Preserves local behavior; prevents PhaseScriptExecution failures on PR agents without private pods. Signed-off-by: William Richter <richter@soramitsu.co.jp>

Detect Cuckoo via or /Pods; fall back to Pods/. Use to invoke. Ensure output directory exists to avoid write failures in CI. Signed-off-by: William Richter <richter@soramitsu.co.jp>

CI env detected (CI=true). Use committed mocks; avoid PhaseScriptExecution flakiness when generator or inputs are not stable on runners. Signed-off-by: William Richter <richter@soramitsu.co.jp>

Re-encode CI skip block with \n and escaped quotes to satisfy Nanaimo/Xcodeproj parser while preserving behavior. Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2025-11-06T10:45:20Z

@codex critique this codebase

chatgpt-codex-connector · 2025-11-06T10:49:09Z

Summary

Added docs/CodexCritique.md documenting scene-management regressions, singleton coupling risks, and cancellation handling gaps observed in the Fearless iOS codebase. docs/CodexCritique.mdL1-L11

Testing

⚠️ Not run (docs-only change)

View task →

…cate typealiases CommonMocks.swift and ModuleMocks.swift: drop SSFModels import and local typealiases that shadow app types, keep single @testable import fearless to avoid symbol ambiguity and redeclarations on CI. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…iases to fearless.* Strip all 'import SSFModels' from committed mocks and add top-level typealiases mapping MetaAccountModel/ChainAccountResponse to fearless module to avoid ambiguous lookup. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…/ChainAsset Fix missing type errors by importing SSFModels at header and explicitly aliasing core types while keeping MetaAccountModel/ChainAccountResponse bound to fearless module. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…cates from generated mocks Add SSFModels bindings (AssetModel, ChainModel, ChainAsset, ChainFormat, AccountId, StakingType, ChainAssetKey) and app-protocol aliases in CuckooTypealiases.swift. Remove header aliases/imports from CommonMocks.swift and ModuleMocks.swift to avoid redeclarations and ambiguity. Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2025-11-06T14:27:45Z

@codex critique this codebase

chatgpt-codex-connector · 2025-11-06T14:30:35Z

Summary

Added docs/CodexCritique.md to document scene-management gaps, singleton-heavy composition, concurrency cancellation risks, and URL handler synchronization issues in the Fearless root stack. docs/CodexCritique.mdL1-L45

Testing

⚠️ Tests not run (docs-only change)

View task →

- FearlessApplication.dropSession(): resolve active foreground window using connectedScenes and UIWindowScene windows instead of deprecated UIApplication.shared.windows.first. - MainTabBarViewFactory.createView(): stop using deprecated keyWindow; resolve ApplicationStatusPresentable window via connectedScenes. - HistoryService.fetchTransactionHistory: avoid invoking completion when the operation was cancelled to prevent teardown crashes. Signed-off-by: William Richter <richter@soramitsu.co.jp>

@mainactor

…ter cancellation-aware; make URL handler thread-safe - RootPresenterFactory: add Dependencies container and overload to support constructor injection while keeping default singleton-backed path. - RootPresenter: mark @mainactor, store and cancel Task handle on reload/deinit; remove extra main queue hops. - URLHandlingService: add concurrent queue with barrier writes and snapshot reads; make registry updates thread-safe. - docs: add CodexCritique.md capturing identified issues and directions. Signed-off-by: William Richter <richter@soramitsu.co.jp>

Swift forbids deinit in extensions; keep cancellation in-class. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…col in dependencies RootPresenterFactory.Dependencies now carries KeystoreProtocol; defaults to SoraKeystore.Keychain(). Signed-off-by: William Richter <richter@soramitsu.co.jp>

…n; align OnboardingViewInput method signature Satisfy nonisolated protocol requirements under Swift 6 while keeping UI mutations on main via DispatchQueue.main.async. Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2025-11-06T16:47:15Z

@codex fix the codecov issues once and for all

chatgpt-codex-connector · 2025-11-06T16:52:53Z

Summary

Added a dedicated Jenkins stage that runs the simulator test matrix with coverage enabled and invokes new scripts to merge .xcresult artifacts and upload them to Codecov. JenkinsfileL45-L53 scripts/ci/export-codecov.shL1-L63 scripts/ci/upload-codecov.shL1-L70
Updated the test-matrix helper to persist result bundles for each configuration, optionally trigger coverage export, and ignored the generated coverage directory in version control. scripts/test-matrix.shL12-L154 .gitignoreL1-L4
Tuned the Codecov configuration and documented the coverage workflow so contributors can reproduce the CI behavior locally. codecov.ymlL1-L36 docs/ci/Codecov.mdL1-L29

Testing

⚠️ Not run (Xcode simulator tooling unavailable in the current container).

View task →

…igger) Signed-off-by: William Richter <richter@soramitsu.co.jp>

…ation - drop older duplicate class from TonChainSelectionTests - keep canonical NetworkWorkerCompatibilityTests in ChainRegistry test group - unblocks fearless.tests simulator test action Signed-off-by: William Richter <richter@soramitsu.co.jp>

- use platform=iOS Simulator,arch=arm64,id=<UDID> in codecov workflow - removes xcodebuild multiple-matching-destinations warning on dual-arch simulator entries Signed-off-by: William Richter <richter@soramitsu.co.jp>

- remove redundant NetworkWorker compatibility tests from ConnectionPoolTests - keep canonical coverage in NetworkWorkerCompatibilityTests - narrows ConnectionPoolTests to connection-pool behavior only Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto · 2026-04-25T12:02:14Z

@codex review

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c79d46664

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ngInfoTests Signed-off-by: William Richter <richter@soramitsu.co.jp>

…ON node Signed-off-by: William Richter <richter@soramitsu.co.jp>

Signed-off-by: William Richter <richter@soramitsu.co.jp>

…ection Signed-off-by: William Richter <richter@soramitsu.co.jp>

Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto · 2026-04-25T19:56:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acc540d17d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93e4246f12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto · 2026-05-01T14:04:01Z

@codex review

chatgpt-codex-connector · 2026-05-01T14:04:15Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

…on error handling Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto · 2026-05-02T17:33:17Z

@codex review

WRRicht3r force-pushed the chore/ci-utils-roadmap-hardening branch 2 times, most recently from 9c91aeb to b7a28f0 Compare November 4, 2025 12:54

WRRicht3r added 11 commits November 5, 2025 17:32

ci: avoid AddressFactory.Type.Type by reverting type(of:) when param …

c549e6b

…already metatype - Replace self.addressFactory = type(of: addressFactory) back to direct assignment in targeted files Signed-off-by: William Richter <richter@soramitsu.co.jp>

ci: conditionalize addressFactory assignment based on param type

cbfe197

- If param is AddressFactory.Type, keep direct assignment - Else assign metatype with type(of:) Signed-off-by: William Richter <richter@soramitsu.co.jp>

ci: force metatype assignment to AddressFactory.self in SSFPolkaswap

8a65e4a

- Normalize property to AddressFactory.Type (dedupe .Type.Type) - Replace self.addressFactory = addressFactory with AddressFactory.self Signed-off-by: William Richter <richter@soramitsu.co.jp>

ci: aggressively rewrite self.addressFactory = addressFactory to Addr…

54fefa2

…essFactory.self - Line-anchored and inline pattern to catch spacing/comments variants in targeted files Signed-off-by: William Richter <richter@soramitsu.co.jp>

ci: flatten AddressFactory.Type.Type with flexible dot spacing + targ…

5869ace

…et files Signed-off-by: William Richter <richter@soramitsu.co.jp>

build: robust Cuckoo guard and path resolution

3454da4

Detect Cuckoo via or /Pods; fall back to Pods/. Use to invoke. Ensure output directory exists to avoid write failures in CI. Signed-off-by: William Richter <richter@soramitsu.co.jp>

test(ci): skip Cuckoo mock generation on CI

2cfe84b

CI env detected (CI=true). Use committed mocks; avoid PhaseScriptExecution flakiness when generator or inputs are not stable on runners. Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: escape CI guard in PBX shellScript strings for CocoaPods

7386208

Re-encode CI skip block with \n and escaped quotes to satisfy Nanaimo/Xcodeproj parser while preserving behavior. Signed-off-by: William Richter <richter@soramitsu.co.jp>

soramitsu deleted a comment from chatgpt-codex-connector Bot Nov 6, 2025

WRRicht3r added 4 commits November 6, 2025 12:08

WRRicht3r added 5 commits November 6, 2025 15:32

fix(root): move deinit into class body to satisfy Swift rules

df58856

Swift forbids deinit in extensions; keep cancellation in-class. Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(root): use KeystoreProtocol instead of non-existent KeychainProto…

535d164

…col in dependencies RootPresenterFactory.Dependencies now carries KeystoreProtocol; defaults to SoraKeystore.Keychain(). Signed-off-by: William Richter <richter@soramitsu.co.jp>

test: import SSFModels into test mocks to fix ChainModel types (CI tr…

00b7a64

…igger) Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r added 3 commits April 25, 2026 13:04

fix(ci): set explicit simulator arch for codecov destination

d53110a

- use platform=iOS Simulator,arch=arm64,id=<UDID> in codecov workflow - removes xcodebuild multiple-matching-destinations warning on dual-arch simulator entries Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r added 2 commits April 25, 2026 14:06

test(storage): split AssetModelMapper tests into dedicated file

3ed25a1

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(ci): prefer exact simulator name match before pattern fallback

a946362

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread fearless/ApplicationLayer/Services/Balance/RemoteSubscription/AccountInfoRemoteService.swift Outdated

Comment thread fearless/Common/Services/ChainRegistry/ChainRegistry.swift Outdated

WRRicht3r added 8 commits April 25, 2026 14:15

test(integration): remove unused runtime/connection bindings in Staki…

95ec538

…ngInfoTests Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(balance): preserve genshiro equilibrium path and honor selected T…

63db632

…ON node Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(ci): resolve simulator destination by name+os with udid fallback

e7ff011

Signed-off-by: William Richter <richter@soramitsu.co.jp>

test(regression): cover genshiro equilibrium routing and TON node sel…

57a070f

…ection Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(balance): align genshiro equilibrium routing in storage service

9ca00e7

Signed-off-by: William Richter <richter@soramitsu.co.jp>

test(ton): cover empty-node resolver edge case

57f4b6f

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(staking): remove transient weak capture in stash provider logging

99b849a

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(chain-registry): avoid optional debug interpolation in error log

acc540d

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread fearless/ApplicationLayer/Services/Balance/AccountInfo/TonRemoteBalanceFetching.swift Outdated

Comment thread fearless/ApplicationLayer/TonJettonInjector.swift Outdated

fix(ci): harden simulator UDID extraction from selector output

93e4246

Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto reviewed Apr 26, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 26, 2026

View reviewed changes

Comment thread fearless/Common/Services/ChainRegistry/ChainRegistry.swift Outdated

WRRicht3r added 6 commits May 1, 2026 10:41

fix: harden ton balances and add sora nexus xor defaults

e9a9d4c

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: stabilize codecov simulator selection and spm patching

4f491d8

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: harden simulator selection and package resolution in test flows

622eaa3

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: finalize ton parsing and sora nexus asset wiring

dcb5a58

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(ci): harden simulator UDID parsing and arm64 destination

2bac02d

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix(ci): harden codecov simulator selection and error surfacing

40355a9

Signed-off-by: William Richter <richter@soramitsu.co.jp>

refactor(balance): remove dead ethereum fetch ops and harden completi…

a5081bd

…on error handling Signed-off-by: William Richter <richter@soramitsu.co.jp>

Conversation

WRRicht3r commented Sep 24, 2025

Uh oh!

WRRicht3r commented Nov 6, 2025

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2025

Uh oh!

WRRicht3r commented Nov 6, 2025

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2025

Uh oh!

WRRicht3r commented Nov 6, 2025

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2025

Uh oh!

takemiyamakoto commented Apr 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

takemiyamakoto commented Apr 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

takemiyamakoto left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

takemiyamakoto commented May 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 1, 2026

Uh oh!

takemiyamakoto commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants