Implement more reader operations on the URI Template router#2383
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/core/uritemplate/uritemplate_router_view.cc">
<violation number="1" location="src/core/uritemplate/uritemplate_router_view.cc:998">
P1: The new path-entry readers rely on `assert` instead of runtime bounds checks, so release builds can read out of bounds on malformed router data.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 2254676 | Previous: 9d2f9fe | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.511488727141553 ns/iter |
2.4640767945217847 ns/iter |
1.02 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.179222096130346 ns/iter |
2.467000198606198 ns/iter |
0.88 |
Regex_Period_Asterisk |
2.5421248526334113 ns/iter |
2.472587955156708 ns/iter |
1.03 |
Regex_Group_Period_Asterisk_Group |
2.1930164384252713 ns/iter |
2.460663248575311 ns/iter |
0.89 |
Regex_Period_Plus |
3.113656845322861 ns/iter |
3.866840716575551 ns/iter |
0.81 |
Regex_Period |
2.8012825787431597 ns/iter |
3.1709311954331096 ns/iter |
0.88 |
Regex_Caret_Period_Plus_Dollar |
3.192599370610034 ns/iter |
2.5105139641866088 ns/iter |
1.27 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.8009296549872578 ns/iter |
2.469554133097197 ns/iter |
1.13 |
Regex_Caret_Period_Asterisk_Dollar |
3.741548652284318 ns/iter |
3.8691229107729894 ns/iter |
0.97 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.178565366632217 ns/iter |
3.8872444745263435 ns/iter |
0.56 |
Regex_Caret_X_Hyphen |
6.262547384784291 ns/iter |
7.313068227249595 ns/iter |
0.86 |
Regex_Period_Md_Dollar |
27.366280844341375 ns/iter |
26.64900927380742 ns/iter |
1.03 |
Regex_Caret_Slash_Period_Asterisk |
6.534667594804561 ns/iter |
7.736282698122984 ns/iter |
0.84 |
Regex_Caret_Period_Range_Dollar |
3.734568221246988 ns/iter |
2.4681957726912436 ns/iter |
1.51 |
Regex_Nested_Backtrack |
38.30390869921431 ns/iter |
37.06600437282049 ns/iter |
1.03 |
JSON_Array_Of_Objects_Unique |
484.8084212467774 ns/iter |
502.7075990000185 ns/iter |
0.96 |
JSON_Parse_1 |
5687.881003180852 ns/iter |
5637.714619074636 ns/iter |
1.01 |
JSON_Parse_Real |
11065.528281396548 ns/iter |
10321.77327779756 ns/iter |
1.07 |
JSON_Parse_Decimal |
10902.057597886716 ns/iter |
11205.280696434751 ns/iter |
0.97 |
JSON_Parse_Schema_ISO_Language |
3584930.0663261726 ns/iter |
3696043.3526312383 ns/iter |
0.97 |
JSON_Fast_Hash_Helm_Chart_Lock |
66.10023441236716 ns/iter |
79.31497021463124 ns/iter |
0.83 |
JSON_Equality_Helm_Chart_Lock |
161.95968674332778 ns/iter |
165.604229592608 ns/iter |
0.98 |
JSON_Divisible_By_Decimal |
245.43423691236544 ns/iter |
248.0182080560034 ns/iter |
0.99 |
JSON_String_Equal/10 |
5.9232554785701765 ns/iter |
5.627392382764153 ns/iter |
1.05 |
JSON_String_Equal/100 |
6.547526835538645 ns/iter |
6.335637668667756 ns/iter |
1.03 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9354969702578804 ns/iter |
1.054696869715504 ns/iter |
0.89 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.801640557499432 ns/iter |
12.375426850461881 ns/iter |
1.20 |
JSON_String_Fast_Hash/10 |
2.8017310357405165 ns/iter |
2.8242865163698645 ns/iter |
0.99 |
JSON_String_Fast_Hash/100 |
2.8091905924521727 ns/iter |
2.8181056412471492 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.707317090059936 ns/iter |
2.4605574544380113 ns/iter |
1.10 |
JSON_String_Key_Hash/100 |
9.02454215171323 ns/iter |
7.729699971513989 ns/iter |
1.17 |
JSON_Object_Defines_Miss_Same_Length |
3.7513439922350322 ns/iter |
4.2241934594504675 ns/iter |
0.89 |
JSON_Object_Defines_Miss_Too_Small |
3.7406405364162025 ns/iter |
4.219724682723017 ns/iter |
0.89 |
JSON_Object_Defines_Miss_Too_Large |
3.7424175686797128 ns/iter |
4.222487955122872 ns/iter |
0.89 |
Pointer_Object_Traverse |
23.986344270466212 ns/iter |
32.33646450977628 ns/iter |
0.74 |
Pointer_Object_Try_Traverse |
27.903353001141294 ns/iter |
36.203254450818314 ns/iter |
0.77 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
223.63085936376132 ns/iter |
176.5747249617907 ns/iter |
1.27 |
Pointer_Walker_Schema_ISO_Language |
3051640.1004368113 ns/iter |
3221355.5825689267 ns/iter |
0.95 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1443923.4421489395 ns/iter |
1438536.8530022318 ns/iter |
1.00 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
2047327.9217389643 ns/iter |
2187230.340175781 ns/iter |
0.94 |
Pointer_Position_Tracker_Get_Deeply_Nested |
697.0260001304285 ns/iter |
690.9949092509119 ns/iter |
1.01 |
Schema_Frame_WoT_References |
5311397.664233954 ns/iter |
5297436.285714059 ns/iter |
1.00 |
Schema_Frame_OMC_References |
21798744.406250846 ns/iter |
22840088.29999872 ns/iter |
0.95 |
Schema_Frame_OMC_Locations |
19810333.264705848 ns/iter |
20771855.852943003 ns/iter |
0.95 |
Schema_Frame_ISO_Language_Locations |
103898665.16667704 ns/iter |
101881048.1666795 ns/iter |
1.02 |
Schema_Frame_KrakenD_References |
43387361.11765229 ns/iter |
42239885.94117814 ns/iter |
1.03 |
Schema_Frame_KrakenD_Reachable |
626568787.9999859 ns/iter |
609180211.0000799 ns/iter |
1.03 |
Schema_Iterator_ISO_Language |
3039381.2813851633 ns/iter |
3134785.9551571608 ns/iter |
0.97 |
Schema_Frame_ISO_Language_Locations_To_JSON |
112550669.60000022 ns/iter |
114696958.50000031 ns/iter |
0.98 |
Schema_Tracker_ISO_Language |
4998305.028985452 ns/iter |
4826947.056338206 ns/iter |
1.04 |
Schema_Tracker_ISO_Language_To_JSON |
19460342.19444452 ns/iter |
17950815.128202546 ns/iter |
1.08 |
Schema_Format_ISO_Language_To_JSON |
114836815.49998437 ns/iter |
112224390.83333786 ns/iter |
1.02 |
Schema_Bundle_Meta_2020_12 |
1676562.9328528156 ns/iter |
1664597.5506168534 ns/iter |
1.01 |
Schema_Frame_Many_Resources_References |
390574964.9999848 ns/iter |
381113693.50002635 ns/iter |
1.02 |
EditorSchema_ForEditor_EmbeddedResources |
14163545.714293888 ns/iter |
14025875.619993258 ns/iter |
1.01 |
URITemplateRouter_Create |
31201.886561104828 ns/iter |
29499.54289200343 ns/iter |
1.06 |
URITemplateRouter_Match |
195.34554432147536 ns/iter |
178.5522714591546 ns/iter |
1.09 |
URITemplateRouter_Match_BasePath |
201.60361868989767 ns/iter |
212.97613056990966 ns/iter |
0.95 |
URITemplateRouterView_Restore |
8124.205401742685 ns/iter |
8770.266419970232 ns/iter |
0.93 |
URITemplateRouterView_Match |
146.1782857574444 ns/iter |
143.62432595771247 ns/iter |
1.02 |
URITemplateRouterView_Match_BasePath |
160.595608215423 ns/iter |
172.12401044115614 ns/iter |
0.93 |
URITemplateRouterView_Arguments |
456.30954434684867 ns/iter |
469.3384622709066 ns/iter |
0.97 |
JSONL_Parse_Large |
10731683.138461588 ns/iter |
9791718.388888802 ns/iter |
1.10 |
JSONL_Parse_Large_GZIP |
12066433.379310371 ns/iter |
11125746.682539882 ns/iter |
1.08 |
HTML_Build_Table_100000 |
63744678.199998364 ns/iter |
86994876.3750017 ns/iter |
0.73 |
HTML_Render_Table_100000 |
5462594.773437246 ns/iter |
5015393.726618882 ns/iter |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 2254676 | Previous: 9d2f9fe | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.0794136662525577 ns/iter |
1.795197347874862 ns/iter |
1.16 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.9778851644909752 ns/iter |
1.9208597687210394 ns/iter |
1.03 |
Regex_Period_Asterisk |
2.1908116675893314 ns/iter |
1.8637781352617278 ns/iter |
1.18 |
Regex_Group_Period_Asterisk_Group |
2.1688377185784486 ns/iter |
1.819904927758781 ns/iter |
1.19 |
Regex_Period_Plus |
2.776393087276719 ns/iter |
2.080144921742322 ns/iter |
1.33 |
Regex_Period |
2.923765838545301 ns/iter |
2.078964606970805 ns/iter |
1.41 |
Regex_Caret_Period_Plus_Dollar |
3.0019211395515786 ns/iter |
2.0789001657892805 ns/iter |
1.44 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.814490302887156 ns/iter |
2.1111901534864597 ns/iter |
1.33 |
Regex_Caret_Period_Asterisk_Dollar |
2.298389554521032 ns/iter |
2.0725052953153416 ns/iter |
1.11 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.115804987893207 ns/iter |
2.5030927351059153 ns/iter |
0.85 |
Regex_Caret_X_Hyphen |
7.69456487462877 ns/iter |
7.817423954016403 ns/iter |
0.98 |
Regex_Period_Md_Dollar |
25.213986732535727 ns/iter |
19.40263917683798 ns/iter |
1.30 |
Regex_Caret_Slash_Period_Asterisk |
8.869404059180885 ns/iter |
9.861116835333666 ns/iter |
0.90 |
Regex_Caret_Period_Range_Dollar |
1.9117635111305673 ns/iter |
2.5584254662673045 ns/iter |
0.75 |
Regex_Nested_Backtrack |
34.946213933795846 ns/iter |
32.46634520641296 ns/iter |
1.08 |
JSON_Array_Of_Objects_Unique |
427.44715930004065 ns/iter |
416.1927084842832 ns/iter |
1.03 |
JSON_Parse_1 |
4390.06948897381 ns/iter |
5963.623358267315 ns/iter |
0.74 |
JSON_Parse_Real |
7026.645533693076 ns/iter |
8016.029455984651 ns/iter |
0.88 |
JSON_Parse_Decimal |
9890.868965291036 ns/iter |
10490.843100861706 ns/iter |
0.94 |
JSON_Parse_Schema_ISO_Language |
4870793.439716775 ns/iter |
5254572.50000045 ns/iter |
0.93 |
JSON_Fast_Hash_Helm_Chart_Lock |
67.25444351149422 ns/iter |
68.86911215669281 ns/iter |
0.98 |
JSON_Equality_Helm_Chart_Lock |
160.70797757026423 ns/iter |
161.97858311631964 ns/iter |
0.99 |
JSON_Divisible_By_Decimal |
193.70803025619617 ns/iter |
241.5913608849685 ns/iter |
0.80 |
JSON_String_Equal/10 |
7.30935888696793 ns/iter |
8.61133777061086 ns/iter |
0.85 |
JSON_String_Equal/100 |
6.695334345238465 ns/iter |
7.643524492672091 ns/iter |
0.88 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.8253367132002982 ns/iter |
0.8642919118961049 ns/iter |
0.95 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
4.515435191860675 ns/iter |
4.299281918868109 ns/iter |
1.05 |
JSON_String_Fast_Hash/10 |
2.9887255814464484 ns/iter |
2.6426758518340696 ns/iter |
1.13 |
JSON_String_Fast_Hash/100 |
3.359041037899458 ns/iter |
2.5285666063127734 ns/iter |
1.33 |
JSON_String_Key_Hash/10 |
1.8001303746305695 ns/iter |
1.9260937453144624 ns/iter |
0.93 |
JSON_String_Key_Hash/100 |
2.9759969923973055 ns/iter |
2.9628649749222906 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.08082645248677 ns/iter |
3.1075759667476874 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Too_Small |
2.860760800763942 ns/iter |
2.7133318174904417 ns/iter |
1.05 |
JSON_Object_Defines_Miss_Too_Large |
2.6319259953513394 ns/iter |
2.6869536859069973 ns/iter |
0.98 |
Pointer_Object_Traverse |
15.36351838270139 ns/iter |
17.69320811930062 ns/iter |
0.87 |
Pointer_Object_Try_Traverse |
23.240155979804612 ns/iter |
22.666405914016174 ns/iter |
1.03 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
158.4610137988707 ns/iter |
183.23495031241617 ns/iter |
0.86 |
Pointer_Walker_Schema_ISO_Language |
5090338.750000001 ns/iter |
5695739.681416137 ns/iter |
0.89 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1467967.8239094382 ns/iter |
1371032.1146341013 ns/iter |
1.07 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1853890.413294813 ns/iter |
1640318.773494314 ns/iter |
1.13 |
Pointer_Position_Tracker_Get_Deeply_Nested |
546.6580543698253 ns/iter |
414.6025844557666 ns/iter |
1.32 |
Schema_Frame_WoT_References |
6305946.250000715 ns/iter |
5870691.456897444 ns/iter |
1.07 |
Schema_Frame_OMC_References |
33388158.71428497 ns/iter |
32929176.57142338 ns/iter |
1.01 |
Schema_Frame_OMC_Locations |
36218697.47826167 ns/iter |
31927594.217390634 ns/iter |
1.13 |
Schema_Frame_ISO_Language_Locations |
90378784.6666546 ns/iter |
107435983.20000274 ns/iter |
0.84 |
Schema_Frame_KrakenD_References |
65700112.49999652 ns/iter |
64997402.77776154 ns/iter |
1.01 |
Schema_Frame_KrakenD_Reachable |
752794873.9999602 ns/iter |
636395041.0002416 ns/iter |
1.18 |
Schema_Iterator_ISO_Language |
3828741.580310785 ns/iter |
2819924.5169080887 ns/iter |
1.36 |
Schema_Frame_ISO_Language_Locations_To_JSON |
128456760.2500033 ns/iter |
105786972.33336242 ns/iter |
1.21 |
Schema_Tracker_ISO_Language |
8895333.33333334 ns/iter |
6333630.135800995 ns/iter |
1.40 |
Schema_Tracker_ISO_Language_To_JSON |
17617014.34374885 ns/iter |
15641591.650000919 ns/iter |
1.13 |
Schema_Format_ISO_Language_To_JSON |
94061053.57142484 ns/iter |
107371524.99996227 ns/iter |
0.88 |
Schema_Bundle_Meta_2020_12 |
1646351.5972592887 ns/iter |
1432362.7453193844 ns/iter |
1.15 |
Schema_Frame_Many_Resources_References |
358314270.4999887 ns/iter |
326481875.0000131 ns/iter |
1.10 |
EditorSchema_ForEditor_EmbeddedResources |
12879396.340419222 ns/iter |
12965032.650011685 ns/iter |
0.99 |
URITemplateRouter_Create |
30738.588023559067 ns/iter |
28219.474322122558 ns/iter |
1.09 |
URITemplateRouter_Match |
182.63049489850988 ns/iter |
184.17164672459464 ns/iter |
0.99 |
URITemplateRouter_Match_BasePath |
232.57520246069902 ns/iter |
212.28594958531892 ns/iter |
1.10 |
URITemplateRouterView_Restore |
10748.673579217326 ns/iter |
16064.34785955494 ns/iter |
0.67 |
URITemplateRouterView_Match |
156.21089246563105 ns/iter |
171.65273775992165 ns/iter |
0.91 |
URITemplateRouterView_Match_BasePath |
178.0724952815312 ns/iter |
166.69155999579885 ns/iter |
1.07 |
URITemplateRouterView_Arguments |
590.0191584541776 ns/iter |
462.8169091779403 ns/iter |
1.27 |
JSONL_Parse_Large |
15960821.428565655 ns/iter |
14877662.130436912 ns/iter |
1.07 |
JSONL_Parse_Large_GZIP |
16335259.615382314 ns/iter |
13648236.702126868 ns/iter |
1.20 |
HTML_Build_Table_100000 |
77516641.69998094 ns/iter |
67447366.60000399 ns/iter |
1.15 |
HTML_Render_Table_100000 |
5154429.589999836 ns/iter |
3729363.8157890253 ns/iter |
1.38 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
Details
| Benchmark suite | Current: 2254676 | Previous: 9d2f9fe | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
7.508543526787902 ns/iter |
7.49954129464468 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.521146205355933 ns/iter |
7.500391964285313 ns/iter |
1.00 |
Regex_Period_Asterisk |
7.544328125000785 ns/iter |
7.494426785714024 ns/iter |
1.01 |
Regex_Group_Period_Asterisk_Group |
7.504438392857082 ns/iter |
7.492945312501981 ns/iter |
1.00 |
Regex_Period_Plus |
9.671031653256486 ns/iter |
9.663757992572178 ns/iter |
1.00 |
Regex_Period |
9.691552188878207 ns/iter |
9.665803124999428 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
9.697763795993792 ns/iter |
9.723168706591881 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
9.71821562499997 ns/iter |
9.661499956867278 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
7.533141741072415 ns/iter |
7.539921874999728 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.52487589285725 ns/iter |
7.502595535714006 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
11.778723214283511 ns/iter |
11.745007142857439 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
37.89094218052824 ns/iter |
37.35629171413121 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
11.311937500000369 ns/iter |
11.281935937500265 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
9.713495312499987 ns/iter |
9.669299956832253 ns/iter |
1.00 |
Regex_Nested_Backtrack |
46.59103061080517 ns/iter |
46.16614374999983 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
468.805751965589 ns/iter |
470.8898818950048 ns/iter |
1.00 |
JSON_Parse_1 |
7897.679687499501 ns/iter |
8458.539062498208 ns/iter |
0.93 |
JSON_Parse_Real |
15976.607142858615 ns/iter |
15619.261160715327 ns/iter |
1.02 |
JSON_Parse_Decimal |
15685.93973214405 ns/iter |
15960.781249998287 ns/iter |
0.98 |
JSON_Parse_Schema_ISO_Language |
6014291.964285283 ns/iter |
6058257.142858079 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
61.49700000000686 ns/iter |
57.81403571428914 ns/iter |
1.06 |
JSON_Equality_Helm_Chart_Lock |
262.65342857137904 ns/iter |
260.09693795080915 ns/iter |
1.01 |
JSON_Divisible_By_Decimal |
249.61815294445785 ns/iter |
251.254607142885 ns/iter |
0.99 |
JSON_String_Equal/10 |
12.260725000000354 ns/iter |
12.317490625001426 ns/iter |
1.00 |
JSON_String_Equal/100 |
12.941682531512228 ns/iter |
13.127039285714254 ns/iter |
0.99 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.2013940625001283 ns/iter |
2.2052212500000223 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
12.975791071426102 ns/iter |
12.891051785715035 ns/iter |
1.01 |
JSON_String_Fast_Hash/10 |
3.137602232142862 ns/iter |
3.1340040178570967 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
3.1410035714287687 ns/iter |
3.1415232142860208 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
3.788185707521159 ns/iter |
3.76328517185044 ns/iter |
1.01 |
JSON_String_Key_Hash/100 |
14.37155803571447 ns/iter |
14.455484533683773 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Same_Length |
5.125175999999101 ns/iter |
5.020158928571408 ns/iter |
1.02 |
JSON_Object_Defines_Miss_Too_Small |
3.7809026718196908 ns/iter |
3.763835886135973 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.80148106463996 ns/iter |
3.7625683861388786 ns/iter |
1.01 |
Pointer_Object_Traverse |
42.65112149740865 ns/iter |
42.60404374998927 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.19502678571075 ns/iter |
52.25338999998712 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
150.39149553567808 ns/iter |
149.13399111006822 ns/iter |
1.01 |
Pointer_Walker_Schema_ISO_Language |
11716515.624996759 ns/iter |
11591466.071426535 ns/iter |
1.01 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1884934.0625003208 ns/iter |
2283750.357142773 ns/iter |
0.83 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
3114535.6807511733 ns/iter |
3154307.203390552 ns/iter |
0.99 |
Pointer_Position_Tracker_Get_Deeply_Nested |
604.584933035771 ns/iter |
631.8266741069627 ns/iter |
0.96 |
Schema_Frame_WoT_References |
9799654.666664235 ns/iter |
9940118.74999856 ns/iter |
0.99 |
Schema_Frame_OMC_References |
42668905.882344596 ns/iter |
44313126.6666569 ns/iter |
0.96 |
Schema_Frame_OMC_Locations |
40126364.70587067 ns/iter |
41255023.529402025 ns/iter |
0.97 |
Schema_Frame_ISO_Language_Locations |
193396299.99997973 ns/iter |
197099233.333347 ns/iter |
0.98 |
Schema_Frame_KrakenD_References |
87203211.11112148 ns/iter |
90911271.42856489 ns/iter |
0.96 |
Schema_Frame_KrakenD_Reachable |
510597999.9998453 ns/iter |
543236100.0000583 ns/iter |
0.94 |
Schema_Iterator_ISO_Language |
6187956.2500004275 ns/iter |
6465954.464285265 ns/iter |
0.96 |
Schema_Frame_ISO_Language_Locations_To_JSON |
285023700.00001067 ns/iter |
291063549.99998987 ns/iter |
0.98 |
Schema_Tracker_ISO_Language |
9973506.250002373 ns/iter |
10346990.666666897 ns/iter |
0.96 |
Schema_Tracker_ISO_Language_To_JSON |
48173628.57142728 ns/iter |
52571810.00001765 ns/iter |
0.92 |
Schema_Format_ISO_Language_To_JSON |
199682199.9999459 ns/iter |
206238600.00000605 ns/iter |
0.97 |
Schema_Bundle_Meta_2020_12 |
2823854.618479955 ns/iter |
2859689.830513154 ns/iter |
0.99 |
Schema_Frame_Many_Resources_References |
1513346799.9999084 ns/iter |
1479276799.9999797 ns/iter |
1.02 |
EditorSchema_ForEditor_EmbeddedResources |
28607699.999984108 ns/iter |
30019654.545433447 ns/iter |
0.95 |
URITemplateRouter_Create |
39594.31361608066 ns/iter |
39504.91555916141 ns/iter |
1.00 |
URITemplateRouter_Match |
214.89171708800401 ns/iter |
213.98009374998142 ns/iter |
1.00 |
URITemplateRouter_Match_BasePath |
251.26064285708645 ns/iter |
248.77625000004045 ns/iter |
1.01 |
URITemplateRouterView_Restore |
30761.745535709146 ns/iter |
33431.88469848161 ns/iter |
0.92 |
URITemplateRouterView_Match |
156.7298214285679 ns/iter |
156.26772321429678 ns/iter |
1.00 |
URITemplateRouterView_Match_BasePath |
180.9819808693319 ns/iter |
180.71503442287747 ns/iter |
1.00 |
URITemplateRouterView_Arguments |
446.4841393346517 ns/iter |
448.09713443825945 ns/iter |
1.00 |
JSONL_Parse_Large |
27626807.999995437 ns/iter |
28076003.999995008 ns/iter |
0.98 |
JSONL_Parse_Large_GZIP |
27214850.000002746 ns/iter |
28342072.00000492 ns/iter |
0.96 |
HTML_Build_Table_100000 |
86981085.71427707 ns/iter |
87676542.85715511 ns/iter |
0.99 |
HTML_Render_Table_100000 |
7937132.222221205 ns/iter |
8214263.999998366 ns/iter |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 2254676 | Previous: 9d2f9fe | Ratio |
|---|---|---|---|
HTML_Build_Table_100000 |
61874815.63636704 ns/iter |
69465244.90001592 ns/iter |
0.89 |
HTML_Render_Table_100000 |
5238717.360901873 ns/iter |
10121034.785713943 ns/iter |
0.52 |
JSONL_Parse_Large |
12524973.482141733 ns/iter |
12122162.017241297 ns/iter |
1.03 |
JSONL_Parse_Large_GZIP |
13709669.56000302 ns/iter |
13556413.769230437 ns/iter |
1.01 |
URITemplateRouter_Create |
30785.425591581563 ns/iter |
28683.680085710246 ns/iter |
1.07 |
URITemplateRouter_Match |
177.6270487680124 ns/iter |
146.4704902871871 ns/iter |
1.21 |
URITemplateRouter_Match_BasePath |
199.80663711024252 ns/iter |
165.33524371056924 ns/iter |
1.21 |
URITemplateRouterView_Restore |
7707.4805744342075 ns/iter |
3474.655630379545 ns/iter |
2.22 |
URITemplateRouterView_Match |
146.1061650243611 ns/iter |
125.0717863045547 ns/iter |
1.17 |
URITemplateRouterView_Match_BasePath |
167.82538758563868 ns/iter |
142.94278983168786 ns/iter |
1.17 |
URITemplateRouterView_Arguments |
476.67207088838495 ns/iter |
541.9515522210013 ns/iter |
0.88 |
EditorSchema_ForEditor_EmbeddedResources |
13994917.380005063 ns/iter |
12952508.407402597 ns/iter |
1.08 |
Schema_Frame_WoT_References |
5396104.031250459 ns/iter |
5000907.716311762 ns/iter |
1.08 |
Schema_Frame_OMC_References |
21902378.74999923 ns/iter |
21654355.281249594 ns/iter |
1.01 |
Schema_Frame_OMC_Locations |
20229279.235289086 ns/iter |
19634985.14285545 ns/iter |
1.03 |
Schema_Frame_ISO_Language_Locations |
98466563.85713816 ns/iter |
96307524.5714273 ns/iter |
1.02 |
Schema_Frame_KrakenD_References |
38800645.22221953 ns/iter |
39018034.50000645 ns/iter |
0.99 |
Schema_Frame_KrakenD_Reachable |
505060324.0001692 ns/iter |
752847648.999932 ns/iter |
0.67 |
Schema_Iterator_ISO_Language |
3245058.6342591764 ns/iter |
3264327.879070723 ns/iter |
0.99 |
Schema_Frame_ISO_Language_Locations_To_JSON |
211826536.00006536 ns/iter |
202177642.33332977 ns/iter |
1.05 |
Schema_Tracker_ISO_Language |
4602293.039473699 ns/iter |
4573007.730263163 ns/iter |
1.01 |
Schema_Tracker_ISO_Language_To_JSON |
22253072.774197612 ns/iter |
24502216.178567387 ns/iter |
0.91 |
Schema_Format_ISO_Language_To_JSON |
104699858.28571485 ns/iter |
102053924.14286508 ns/iter |
1.03 |
Schema_Bundle_Meta_2020_12 |
1795083.593341078 ns/iter |
1705262.3907793488 ns/iter |
1.05 |
Schema_Frame_Many_Resources_References |
366509285.9999959 ns/iter |
363654338.500055 ns/iter |
1.01 |
Pointer_Object_Traverse |
24.902585265858708 ns/iter |
26.900951781462158 ns/iter |
0.93 |
Pointer_Object_Try_Traverse |
22.14789703628342 ns/iter |
24.552629555894786 ns/iter |
0.90 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
163.0936987717566 ns/iter |
152.31779714806223 ns/iter |
1.07 |
Pointer_Walker_Schema_ISO_Language |
3310032.8301890907 ns/iter |
3367526.920187693 ns/iter |
0.98 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1550080.8362832435 ns/iter |
1411451.5533196982 ns/iter |
1.10 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1771025.7304787675 ns/iter |
2008948.7960343077 ns/iter |
0.88 |
Pointer_Position_Tracker_Get_Deeply_Nested |
531.9662640252708 ns/iter |
482.27929671219556 ns/iter |
1.10 |
JSON_Array_Of_Objects_Unique |
394.58591091996516 ns/iter |
335.766667421911 ns/iter |
1.18 |
JSON_Parse_1 |
7735.272869514275 ns/iter |
6974.81648872526 ns/iter |
1.11 |
JSON_Parse_Real |
11988.632092824915 ns/iter |
11022.086928382669 ns/iter |
1.09 |
JSON_Parse_Decimal |
17828.137235343944 ns/iter |
14842.626842844009 ns/iter |
1.20 |
JSON_Parse_Schema_ISO_Language |
4622873.529801806 ns/iter |
4250489.168673785 ns/iter |
1.09 |
JSON_Fast_Hash_Helm_Chart_Lock |
61.36886987513835 ns/iter |
45.044211567522254 ns/iter |
1.36 |
JSON_Equality_Helm_Chart_Lock |
156.3631849208552 ns/iter |
153.13892250171273 ns/iter |
1.02 |
JSON_Divisible_By_Decimal |
238.16301563890903 ns/iter |
250.16498004323995 ns/iter |
0.95 |
JSON_String_Equal/10 |
6.5109151744859615 ns/iter |
5.685054016546919 ns/iter |
1.15 |
JSON_String_Equal/100 |
7.0738029393867645 ns/iter |
6.79953167308254 ns/iter |
1.04 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.626054697918828 ns/iter |
0.8252245920293577 ns/iter |
0.76 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
25.238975952813487 ns/iter |
17.006986981890567 ns/iter |
1.48 |
JSON_String_Fast_Hash/10 |
1.5581334422749555 ns/iter |
1.1524081280250302 ns/iter |
1.35 |
JSON_String_Fast_Hash/100 |
1.5590332502224984 ns/iter |
1.153173376425145 ns/iter |
1.35 |
JSON_String_Key_Hash/10 |
1.247108028084306 ns/iter |
1.7294774658683176 ns/iter |
0.72 |
JSON_String_Key_Hash/100 |
12.447596093811244 ns/iter |
11.835082159114094 ns/iter |
1.05 |
JSON_Object_Defines_Miss_Same_Length |
3.4393512220648126 ns/iter |
3.3744813505651408 ns/iter |
1.02 |
JSON_Object_Defines_Miss_Too_Small |
3.7402902834993217 ns/iter |
3.4422667470569612 ns/iter |
1.09 |
JSON_Object_Defines_Miss_Too_Large |
3.1163691370786277 ns/iter |
3.5534212452576353 ns/iter |
0.88 |
Regex_Lower_S_Or_Upper_S_Asterisk |
0.6230064229912208 ns/iter |
1.152730107636382 ns/iter |
0.54 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
0.6231036774577012 ns/iter |
1.152305037125781 ns/iter |
0.54 |
Regex_Period_Asterisk |
0.9346422169663856 ns/iter |
0.8644182119527319 ns/iter |
1.08 |
Regex_Group_Period_Asterisk_Group |
0.9355326162554495 ns/iter |
0.8645265495388635 ns/iter |
1.08 |
Regex_Period_Plus |
0.6248474125519575 ns/iter |
1.1522387881492306 ns/iter |
0.54 |
Regex_Period |
0.6226238327906687 ns/iter |
1.1525297359448048 ns/iter |
0.54 |
Regex_Caret_Period_Plus_Dollar |
0.9349202414231205 ns/iter |
0.86428008115302 ns/iter |
1.08 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
0.933867589157623 ns/iter |
0.8648442044741643 ns/iter |
1.08 |
Regex_Caret_Period_Asterisk_Dollar |
0.6232090379605155 ns/iter |
1.1528986226972944 ns/iter |
0.54 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
0.6229538423579157 ns/iter |
1.1532951610676598 ns/iter |
0.54 |
Regex_Caret_X_Hyphen |
4.053106554475574 ns/iter |
3.4570360880076096 ns/iter |
1.17 |
Regex_Period_Md_Dollar |
30.282919542521753 ns/iter |
22.851842718839094 ns/iter |
1.33 |
Regex_Caret_Slash_Period_Asterisk |
4.667188245896165 ns/iter |
3.168005323976699 ns/iter |
1.47 |
Regex_Caret_Period_Range_Dollar |
0.7787194615348383 ns/iter |
1.1522504230854234 ns/iter |
0.68 |
Regex_Nested_Backtrack |
36.319998893183616 ns/iter |
32.96450051735205 ns/iter |
1.10 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com