Skip to content

Fix Cant create ICMP firewall rules on windows#174

Open
alexandrezia wants to merge 1 commit into
sous-chefs:mainfrom
alexandrezia:windows_icmp
Open

Fix Cant create ICMP firewall rules on windows#174
alexandrezia wants to merge 1 commit into
sous-chefs:mainfrom
alexandrezia:windows_icmp

Conversation

@alexandrezia
Copy link
Copy Markdown

Description

on windows icmp rules must not specify port

Issues Resolved

#156

Check List

@ianau74
Copy link
Copy Markdown

ianau74 commented Oct 27, 2017

Can you fix the 2 failing checks so this can get merged into master? They seem like pretty trivial fixes.

@mjavier2k
Copy link
Copy Markdown

Im having the same issue and a merge into master will be appreciated.

@smastrorocco
Copy link
Copy Markdown

Any chance we can get this merged?

@RiverHeart
Copy link
Copy Markdown

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

@alexandre-zia-ifood
Copy link
Copy Markdown

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Hey, it was too long ago, I don't have context about this anymore, please go ahead, no worries.

@RiverHeart
Copy link
Copy Markdown

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Hey, it was too long ago, I don't have context about this anymore, please go ahead, no worries.

Thanks @alexandrezia :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium Will bring visible benefit to the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants