Changed URL to use Ruby's standard URI regex #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I did not know about this. Very cool!
Contributor
|
bump |
| |localhost)(:[0-9]{1,5})?(\/.*)?\z/ix | ||
| URL = URI::regexp(%w(http https)) | ||
|
|
||
| def assert_url(att, error = [att, :not_url]) |
Contributor
There was a problem hiding this comment.
Might make sense to pass the schemes here:
def assert_url(att, schemes = %w(http https), error = [att, :not_url])
if assert_present(att, error)
assert_format(att, URI.regexp(schemes), error)
end
endThis would allow people to use this helper to check other kind of URLs without extra work. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed custom URL regex and used standard regex provided by Ruby for more consistent URL matching. Test case included in test/scrivener_test.rb.