Skip to content

Fix renderer just not working #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Axionyxx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix renderer just not working #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SS14.MapServer/BuildRunners/LocalBuildService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ await process.WaitForExitAsync(cancellationToken)
var log = logBuffer.ToString();
// Bandaid the fact that the map renderer doesn't return an error code when rendering fails

if (process.ExitCode != 0 || LogErrorRegex().IsMatch(log))
if (process.ExitCode != 0 || RendererFailureRegex().IsMatch(log))
{
var exception = new BuildException($"Error while running: {command} {string.Join(' ', arguments)}");
ProcessLocalBuildException(log, "run.log", exception);
Expand Down Expand Up @@ -157,6 +157,6 @@ private void ProcessLocalBuildException(string log, string fileName, Exception e
});
}

[GeneratedRegex("error?|exception|fatal")]
private static partial Regex LogErrorRegex();
[GeneratedRegex(@"(?im)(\[(ERRO|FATL)\])|(^Unhandled exception\.)|(^\s*System\.[\w.]+Exception\b)", RegexOptions.CultureInvariant)]
private static partial Regex RendererFailureRegex();
}