fix: preserve a root cert's ZK receipt on a receipt-less re-send - #91
Merged
Conversation
A root cert re-sent for the same commitment often omits its ZK receipt (the sender assumes the relay still holds it — a valid client optimization). is_better_than accepts the fresher-anchor cert, so the receipt-less cert overwrote the receipt-bearing one and the relay could no longer prove the commitment to a fresh client: every sub-handle then failed with "receipt required". When storing an update whose incoming root cert has no receipt and whose commitment root is unchanged, keep the existing cert_data. The bulk INSERT reads the existing cert_data in-place via a subquery (no extra fetch), and since the value is unchanged the storage- byte trigger nets out. The zone still updates to the fresher anchor. Adds test_receiptless_root_update_preserves_receipt using two_commits_both_finalized (a second commit carries a real receipt).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A root cert re-sent for the same commitment often omits its ZK receipt (the sender assumes the relay still holds it — a valid client optimization). is_better_than accepts the fresher-anchor cert, so the receipt-less cert overwrote the receipt-bearing one and the relay could no longer prove the commitment to a fresh client: every sub-handle then failed with "receipt required"