fix(prove): trim non-subtree keys from both ends of the sorted key slice - #33
Merged
Conversation
Keys diverging from an internal node's prefix with a 0 bit sort before the prefix-matching band, not after it. The single partition_point assumed matching keys came first, so any diverge-left key made it return 0 and silently drop every matching key from the proof — the returned subtree could not replay inserts for the very keys it proved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keys diverging from an internal node's prefix with a 0 bit sort before the prefix-matching band, not after it. The single partition_point assumed matching keys came first, so any diverge-left key made it return 0 and silently drop every matching key from the proof. The returned subtree could not replay inserts for the very keys it proved.