Num trading - #199
Merged
Merged
Conversation
Add `walletfundtransfer`: fund and broadcast one or more externally-signed transfer PSBTs (single input/output, signed with SIGHASH_SINGLE|ANYONECANPAY, input value == output value) as a single transaction. Generalize buy/sell/verify_listing to nums: `Listing.space` becomes `subject` (with a serde alias for back-compat) and resolves @space, #numeric, or num1... A num sale delivers to the buyer's N+1 output and requires a non-zero price. `walletbuy` gains an optional `recipient` so a buyer can fund a purchase and deliver the handle to an external keystore. Add `sign_transfer` (+ regtest `debugsigntransfer`) to produce transfer PSBTs. Update the RPC schema docs. Covered by unit tests (PSBT validation, incl. a real nacho transfer PSBT) and regtest integration tests (single + batch fundtransfer, num sell/buy via numeric and num-id subjects, external delivery).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.