Add step to update spack-packages repo during snapshot #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I am not sure if this is the correct place to do this, but we can relocate the logic as needed. A few questions I had while looking at this.
|
kwryankrattiger
commented
May 16, 2025
| old_date = py_gh_repo.get_commit(old_sha).commit.committer.date | ||
| new_date = py_gh_repo.get_commit(tag.sha).commit.committer.date | ||
| # The if new sha is older than the old sha, don't update | ||
| if old_date > new_date: |
Collaborator
Author
There was a problem hiding this comment.
I think this is safe since all commits going into develop are going to be merge commits.
|
|
||
| spackages_repo = py_github.get_repo("spack/spack-packages", lazy=True) | ||
| # Create the PR | ||
| pr = spackages_repo.create_pull( |
Collaborator
Author
There was a problem hiding this comment.
Should this get an urgent tag?
| ) | ||
| last_commit = pr.get_commits()[pr.commits - 1] | ||
| # Trigger a rebuild everything on the PR to be reviewed by maintainers | ||
| pr.create_comment("@spackbot rebuild everything", last_commit, "", 0) |
Collaborator
Author
There was a problem hiding this comment.
I think this should work with the urgent tag, but I am not sure about timing of the events sent to spackbot and the periodicity of the sync script.
Collaborator
Author
There was a problem hiding this comment.
Use a label to denote a different branch name scheme to use for this type of CI.
kwryankrattiger
force-pushed
the
split_repo_snapshots
branch
2 times, most recently
from
45c292c to
98f5210
Compare
kwryankrattiger
force-pushed
the
split_repo_snapshots
branch
from
69984f1 to
12bc5fa
Compare
kwryankrattiger
force-pushed
the
split_repo_snapshots
branch
from
12bc5fa to
18e896b
Compare
kwryankrattiger
force-pushed
the
split_repo_snapshots
branch
from
18e896b to
83e25da
Compare
kwryankrattiger
force-pushed
the
split_repo_snapshots
branch
from
8736756 to
dc77769
Compare
Buildcache-tools image provides tools for multiple build cache operations. validate-index, publish (to top level), snapshot
| type=int, | ||
| default=2, | ||
| default=3, | ||
| help=("Target layout version to publish (either 2 or 3, defaults to 2)"), |
Collaborator
There was a problem hiding this comment.
Suggested change
| help=("Target layout version to publish (either 2 or 3, defaults to 2)"), | |
| help=("Target layout version to publish (either 2 or 3, defaults to 3)"), |
| if isinstance(project, str): | ||
| project = GL.projects.get(project, lazy=True) | ||
|
|
||
| pipeline = project.pipelines.list(get_all=False, per_page=1, ref=branch, status="success") |
Collaborator
There was a problem hiding this comment.
Note that we're relying on default behavior here, which is to sort by pipeline ID, descending.
I think this is the right thing to do; the only other applicable option would be updated_at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spack-package update to snapshot cron.