axom: Add cxxstd variant for C++20, python variant improvements - #5791
Open
bmhan12 wants to merge 2 commits into
Open
axom: Add cxxstd variant for C++20, python variant improvements#5791bmhan12 wants to merge 2 commits into
bmhan12 wants to merge 2 commits into
Conversation
Contributor
|
Thanks! I appreciate it! |
dtaller
reviewed
Jul 29, 2026
| description="C++ standard to build with", | ||
| ) | ||
|
|
||
| # ----------------------------------------------------------------------- |
Contributor
There was a problem hiding this comment.
You may want to add conflicts if someone sets +cpp14 but also cxxstd=17 for example
Contributor
Author
There was a problem hiding this comment.
The cpp14 variant in its current deprecated state is a misnomer.
It is a no-op the majority of the time, and it is only relevant in a narrow case where you want to build with C++14 with axom <= 0.6.1 & with blt <= 0.5.1 (with or without CUDA).
I've left the variant in but defaulted to false in order to not break some environments in the shared environments that have +cpp14 explicitly defined (configuration would break when spack determines variant no longer exists).
dtaller
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
cxxstdvariant for C++20cpp14variant as deprecated, no longer a hard requirementpythonvariantRelates to: