Skip to content

axom: Add cxxstd variant for C++20, python variant improvements - #5791

Open
bmhan12 wants to merge 2 commits into
spack:developfrom
bmhan12:feature/han12/c_20
Open

axom: Add cxxstd variant for C++20, python variant improvements#5791
bmhan12 wants to merge 2 commits into
spack:developfrom
bmhan12:feature/han12/c_20

Conversation

@bmhan12

@bmhan12 bmhan12 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This PR:

Relates to:

@bmhan12 bmhan12 changed the title axom: Add cxxstd variant for C++20 axom: Add cxxstd variant for C++20, python variant improvements Jul 29, 2026
@spackbot-triage spackbot-triage Bot added dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository conflicts Modifications with a `conflicts()` directive new-variant Modifications to packages' `variant()` directives stand-alone-tests Stand-alone (or smoke) tests for installed packages extends labels Jul 29, 2026
@spackbot-triage
spackbot-triage Bot requested a review from white238 July 29, 2026 16:42
@dtaller

dtaller commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Thanks! I appreciate it!

description="C++ standard to build with",
)

# -----------------------------------------------------------------------

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add conflicts if someone sets +cpp14 but also cxxstd=17 for example

@bmhan12 bmhan12 Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cpp14 variant in its current deprecated state is a misnomer.
It is a no-op the majority of the time, and it is only relevant in a narrow case where you want to build with C++14 with axom <= 0.6.1 & with blt <= 0.5.1 (with or without CUDA).
I've left the variant in but defaulted to false in order to not break some environments in the shared environments that have +cpp14 explicitly defined (configuration would break when spack determines variant no longer exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts Modifications with a `conflicts()` directive dependencies Modifications with a `depends_on()` directive extends new-variant Modifications to packages' `variant()` directives stand-alone-tests Stand-alone (or smoke) tests for installed packages update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants