-
Notifications
You must be signed in to change notification settings - Fork 41
Fix: Repeated Warning Message "Preparation count cannot be negative" #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Iwantexpresso
wants to merge
11
commits into
main
Choose a base branch
from
issue-7156
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text of html 5 validation to avoid both of them running
Triggered by b636151 on branch refs/heads/issue-7156
Triggered by 7f72143 on branch refs/heads/issue-7156
emenslin
approved these changes
Jan 8, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify that inputting a negative CountAMT field in Preparations results in a error and that you cannot save ( this should use the specify Save Blockers and display message "Preparation count cannot be negative")
- Verify that only a single message error message appears( this time the HTML 5 message should appear only and display message "Please Select a value no less than 0")
- (optional) Test in at least one more preparation view/subview
Looks good, message only appears once.
01-08_08.40.mp4
CarolineDenis
approved these changes
Jan 9, 2026
grantfitzsimmons
approved these changes
Jan 14, 2026
Member
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify that inputting a negative CountAMT field in Preparations results in a error and that you cannot save ( this should use the specify Save Blockers and display message "Preparation count cannot be negative")
- Verify that only a single message error message appears( this time the HTML 5 message should appear only and display message "Please Select a value no less than 0")
- (optional) Test in at least one more preparation view/subview
👌
CarolineDenis
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7156
Prevented an issue Cause by both html5 min validation and Specify's negative validation both being triggered at the same time, causing the error popup to display multiple cannot be negative messages to be added to the popup
Note: this error appears after the countAMT field has the
initialize="min=0"field set in its form definition, see instructions below to recreate or follow testing instruction from #6462.Screen.Recording.2025-12-18.at.12.19.27.PM.mov
Checklist
self-explanatory (or properly documented)
Testing instructions
initialize="min=0"to the<cell type="field" id="3" name="countAmt" uitype="text"/>if neededLike this: