PEM-9650 Adding basic unit test coverage for forklift#35
PEM-9650 Adding basic unit test coverage for forklift#35HigashikataZhangsuke wants to merge 13 commits intospectro-v2.9.2from
Conversation
HigashikataZhangsuke
changed the title
![bulwark-spectrocloud[bot]](https://avatars.githubusercontent.com/u/36211249?s=60&v=4){kind=small}
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
- Split CI into parallel jobs (lint, test, verify, build) for faster execution - Upgrade actions to latest versions (checkout@v6, setup-go@v6, codecov@v5) - Add coverage reporting with Codecov for PRs - Add support for spectro-v* branches - Disable build-push-images workflow for fork safety - Remove redundant golangci-lint workflow - Update README badges to point to spectrocloud fork
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
…d golangci-lint action to run with a report output, ensuring better integration with code quality tools.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
…e linting process
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
…ettings to simplify the linting process
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
…further streamline the linting process
…t conditions. The lint job is commented out, and the coverage report now runs only after tests complete, improving workflow clarity and execution.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
…eps to continue on error, improving resilience in the absence of baseline data or SonarQube configuration.
…sed on the presence of SONAR_TOKEN, enhancing flexibility in configuration.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
… workflow, simplifying execution logic.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
…coverage results to Codecov, streamlining the coverage reporting process.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
HigashikataZhangsuke
changed the title
3 participants
Init changes to increase the test coverage to 36%