Open
Conversation
klpoland
added
feature
lucaspar
requested changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds temporal (time-range) selection to web downloads—primarily for DigitalRF capture downloads—by introducing temporal filtering helpers, exposing timing metadata on capture API responses, and wiring a noUiSlider-based UI into the existing web download modal flow.
Changes:
- Add temporal filtering backend plumbing (helper + task/view parameters) to select a subset of capture RF data files by time bounds.
- Extend capture serializers to provide duration/cadence/bounds metadata needed to drive the slider UI.
- Integrate noUiSlider and update templates/JS to show a time-range slider and dynamic file/size labels for capture downloads.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/users/views.py | Accepts start_time/end_time POST params and forwards them to the Celery download task. |
| gateway/sds_gateway/api_methods/tasks.py | Threads start_time/end_time into file collection and adds DigitalRF-only temporal filtering for capture downloads. |
| gateway/sds_gateway/api_methods/helpers/temporal_filtering.py | New helper utilities for DigitalRF filename parsing, OpenSearch bounds lookup, cadence estimation, and time-bounded file selection. |
| gateway/sds_gateway/api_methods/serializers/capture_serializers.py | Adds new timing/size/count fields used by the capture download slider UI. |
| gateway/sds_gateway/templates/base.html | Loads noUiSlider CSS/JS from CDN. |
| gateway/sds_gateway/templates/users/partials/web_download_modal.html | Adds capture-only slider UI + client-side formatting and passes time bounds in the download request. |
| gateway/sds_gateway/static/js/actions/DownloadActionManager.js | Initializes the slider from capture button data attributes and opens the web download modal for captures. |
| gateway/sds_gateway/static/js/file-list.js | Adds capture timing/size/count metadata into capture-row download button attributes (dynamic table). |
| gateway/sds_gateway/templates/users/partials/captures_page_table.html | Adds capture timing/size/count metadata into capture-row download button attributes (server-rendered table). |
| gateway/sds_gateway/templates/users/file_list.html | Includes the web download modal partial for capture downloads. |
| gateway/sds_gateway/templates/users/dataset_list.html | Includes the web download modal partial with item_type="dataset". |
| gateway/sds_gateway/templates/users/published_datasets_list.html | Includes the web download modal partial with item_type="dataset". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gateway/sds_gateway/templates/users/partials/web_download_modal.html
Outdated
Show resolved
Hide resolved
gateway/sds_gateway/templates/users/partials/web_download_modal.html
Outdated
Show resolved
Hide resolved
lucaspar
requested changes
Mar 6, 2026
| * Use web download modal (with temporal slider) when DownloadActionManager is available. | ||
| */ | ||
| handleDownloadCapture(button) { | ||
| if (window.currentDownloadManager && document.getElementById("webDownloadModal")) { |
Member
There was a problem hiding this comment.
This silently fails if the element is not there.
We can reverse logic, raise a pretty "danger" alert to user (or at least a console.err) if element is not present and return.
…r file, catch potential errors
klpoland
force-pushed
the
feature-kpoland-add-drf-time-selection-api
branch
from
7a9a87b to
0aa1c3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select times for web download: