463 support os root #507
Open
463 support os root #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sean9999
force-pushed
the
463-support-os-root
branch
7 times, most recently
from
8b2f983 to
9717843
Compare
Collaborator
|
Thanks @sean9999 I think this is a great addition! If you don't mind, I'd like to wait for 1.25 to be released: we usually try to support two versions. |
Contributor
Author
It's time, boss! =) I had some "only v1.24" conditions in linter tests. I changed it to use I also rebased to the tip of master |
- add method to Fs interface - implement the method in all implementations - added OpenRoot and OpenInRoot - tests - upgrade go version and some transient deps with vulns
sean9999
force-pushed
the
463-support-os-root
branch
4 times, most recently
from
71d4759 to
4f005ee
Compare
use toolchain directive
sean9999
force-pushed
the
463-support-os-root
branch
from
4f005ee to
dc4f19e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for os.Root.
see: https://go.dev/blog/osroot.
This code mainly sticks to just the task at hand, however in order to make CI tests pass, I had to do some very minor clean-ups.
I introduce the interface
Root, which satisfies the same method-set as os.Root.Root is basically a "chroot". It offers a root-relative view into a filesystem that you can't escape.
Root is powered by *rootFs, which simply wraps *BasePathFs, changing the signature slightly so that it satisfies the interface, and the functionality that os.Root provides.