Revert counting missing blobs as checked #1283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jrray
force-pushed
the
push-noyyutqwooox
branch
from
99b1b36 to
6f37d09
Compare
Following up on #1052 there are still spurious test failures in other tests, e.g., sync::sync_test::test_sync_ref_including_annotation_blob, that fail because the spfs config is set to legacy encoding format. These tests that change the config were not putting the config back to defaults, so that could explain the spurious failures depending on the order that tests run. Although, it is suspicious that the tests weren't failing more often if this is the cause. Signed-off-by: J Robert Ray <[email protected]>
Contrary to dc38b37, the `checked_objects` field is documented with "the number of objects checked and found to be okay". Signed-off-by: J Robert Ray <[email protected]>
jrray
force-pushed
the
legacy-format-test-failures
branch
from
fa36f9c to
1f6ef33
Compare
jrray
force-pushed
the
push-noyyutqwooox
branch
from
6f37d09 to
9bc8ee9
Compare
jrray
force-pushed
the
legacy-format-test-failures
branch
2 times, most recently
from
a1e7e7d to
aefab7b
Compare
rydrman
approved these changes
Oct 25, 2025
jrray
force-pushed
the
legacy-format-test-failures
branch
from
aefab7b to
5a0ef59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to dc38b37, the
checked_objectsfield is documented with "the number of objects checked and found to be okay".