fix: harden vector store reliability#570
Merged
zxuexingzhijie merged 12 commits intoJul 26, 2026
Merged
Conversation
zxuexingzhijie
marked this pull request as ready for review
July 25, 2026 14:58
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MetadataAwareSimpleVectorStoreintroduced by refactor: harden DataAgent backend and reuse Spring AI #562 rather than adding a parallel implementation.Why
The previous metadata path was implemented as
similaritySearch("default"). That made existence checks and deletion depend on the active embedding model and similarity ranking, so exact metadata matches could be missed. Replacement also deleted old vectors before the new set was safely established. A model/dimension change, interrupted persistence, stuck embedding status, or an unbounded hybrid request could therefore cause missing recall, data loss, or permanently blocked work.Validation
./mvnw -pl data-agent-management -DskipTests test-compile./mvnw -pl data-agent-management -Dtest='SchemaVectorRecallIntegrationTest,VectorReplacementIntegrationTest,SimpleVectorStorePersistenceIntegrationTest,EmbeddingModelCompatibilityValidatorTest,VectorStoreConfigurationTest,EmbeddingRecoveryMapperIntegrationTest,MetadataAwareSimpleVectorStoreTest' test— 14 passed./mvnw -q -pl data-agent-management test— 1819 passed, 0 failures, 0 errors, 1 skippedEmbeddingModeland realSimpleVectorStore; they do not use Mockito.MilvusVectorStoreIntegrationTestexercises add/search/exact-filter/delete against an actual Milvus server and is gated by-Ddataagent.milvus.integration=true. It was not rerun during the final rebase because the local Docker daemon was unavailable.Notes
main(ff49a5f).application.ymlare intentionally excluded from the commit.