Repository navigation
Support list-valued Kafka binder brokers in Kafka Streams - #3310
Closed
sudhanshubliz wants to merge 1 commit into
Closed
sudhanshubliz wants to merge 1 commit into
sudhanshubliz wants to merge 1 commit into
Conversation
Fixes spring-cloudgh-3307 Signed-off-by: Sudhanshu Ratna Thakur <sudhanshubliz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3307
The Kafka Streams binder falls back to
spring.cloud.stream.kafka.binder.brokerswhen its own broker configuration is left at the default. That fallback read the property as a single string, so indexed properties produced by a YAML list were missed and the default broker remained in use.This change binds both the Streams-specific and shared broker settings as string arrays. It preserves comma-separated values, respects an explicit Streams broker list, and ignores an empty shared setting.
Validation:
main: 6 tests passed.The reporter confirmed they are not working on a fix. Maintainer feedback on the expected configuration behaviour is welcome.