Repository navigation
Fix v88 build break + migrate docs to tfplugindocs (for integrations#3284) - #1
Merged
sprioriello merged 2 commits intoJun 10, 2026
Conversation
…ns#3380) - remove website/docs/r pages (no longer published since integrations#3380) - add examples/resources/ + templates/resources/ for both resources - commit generated docs/resources pages from make generatedocs
3 of 5 tasks
sprioriello
self-requested a review
June 10, 2026 22:52
sprioriello
merged commit Jun 10, 2026
0c797c6
into
sprioriello:feat/organization-security-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As offered in integrations/terraform-provider-github#3284 — this PR targets your
feat/organization-security-configurationbranch with the two fixes needed after recent changes on upstreammain:Commit 1 —
fix: update go-github imports from v86 to v88Mechanical import-path change in the four new Go files. Verified:
go build ./...succeeds,go vet ./github/is clean, and all unit tests inutil_security_configuration_test.gopass (go test ./github/ -run SecurityConfiguration).Commit 2 —
docs: migrate to tfplugindocswebsite/docs/r/*.html.markdownpages (unpublished since upstream chore: Use tf plugin docs integrations/terraform-provider-github#3380)examples/resources/github_{organization,enterprise}_security_configuration/(resource_1.tf+import.sh)templates/resources/{organization,enterprise}_security_configuration.md.tmplfollowing the conventions of the most recently updated template (repository_collaborators.md.tmpl): intro prose +{{ .SchemaMarkdown }}+ import boilerplatemake generatedocs;tfplugindocs validatepassesOnce you merge this into your branch, integrations#3284 should build green again and the docs will publish to the Registry. I deliberately left the three minor observations from my review comment (e.g.
Computed: trueonsecret_scanning_delegated_bypass_options) out of this PR — your call whether to address those.Next step on my side: working on sandbox org/enterprise access to run the acceptance tests (
TF_ACC=1) including the GHAS-dependent attributes; I'll report results on integrations#3284.