Show a simple Pixi setup#477
Conversation
paugier
force-pushed
the
try-pixi
branch
2 times, most recently
from
99056e5 to
1c1679b
Compare
paugier
force-pushed
the
try-pixi
branch
2 times, most recently
from
c78d490 to
42cd3ea
Compare
antocuni
left a comment
antocuni
left a comment
There was a problem hiding this comment.
I'm super happy about this 🎉.
Left some minor comments.
| - name: Run tests | ||
| run: | | ||
| pixi run pytest -n auto -m "not mypy" --junit-xml=test-results.xml | ||
|
|
There was a problem hiding this comment.
if I understand correctly this PR runs the whole test suite twice (one with pixi, one with pip)?
I'd prefer to avoid that, I think it's enough a smoke test such as spy build -x examples/hello.spy to ensure that things generally work.
There was a problem hiding this comment.
I simplified a lot the workflow checking Pixi setup. Only a smoke test is run.
| [tool.pixi.activation.env] | ||
| C_INCLUDE_PATH = "$PIXI_PROJECT_ROOT/.pixi/envs/default/include:$C_INCLUDE_PATH" | ||
| LIBRARY_PATH = "$PIXI_PROJECT_ROOT/.pixi/envs/default/lib:$LIBRARY_PATH" | ||
| DYLD_LIBRARY_PATH = "$PIXI_PROJECT_ROOT/.pixi/envs/default/lib:$DYLD_LIBRARY_PATH" |
There was a problem hiding this comment.
I guess this is needed to be able to link libgc?
If so, it's worth adding a comment
| test-xdist = "pytest -n auto -m 'not mypy'" | ||
| check-lint = "ruff check ." | ||
| check-fmt = "ruff format --check ." | ||
| fmt-py = "ruff format ." |
There was a problem hiding this comment.
I never used pixi before so I don't know whether these are conventional names or ad-hoc.
If they are ad-hoc, what about usinf ruff-check, ruff-format-check and ruff-format? They look much more intuitive to me :)
|
@paugier after merging, the pixi workflow fails: do you feel like investigating it? |
2 participants
Related to #476
Setup a dev env
Other useful commands (with tab auto-completion)