Fix var NULL ptr global and the tests#488
Open
paugier wants to merge 2 commits intospylang:mainfrom
Open
Conversation
paugier
force-pushed
the
var-NULL-global
branch
from
9278f56 to
2d849c7
Compare
Contributor
Author
|
This one is another very small and simple PR. Just slightly modify a test to get the SPy bug and the fix, about a quite evident logic bug (diff by @antocuni). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antocuni, this is a very simple PR just to fix
var BUF: gc_ptr[u8] = gc_ptr[u8].NULLat the global level.The diff was given by @antocuni in #484 (comment) and I just modified two existing tests.
It seems to me that it is not very useful to have a constant null global pointer so I added
varto the related tests, so that they fail.Is it correct?