Add support for getting db session form context#3772
Closed
rodionstolyarov wants to merge 1 commit intosqlc-dev:mainfrom
rodionstolyarov:get-db-from-context
Closed
Add support for getting db session form context#3772rodionstolyarov wants to merge 1 commit intosqlc-dev:mainfrom rodionstolyarov:get-db-from-context
rodionstolyarov wants to merge 1 commit intosqlc-dev:mainfrom
rodionstolyarov:get-db-from-context
Conversation
Collaborator
|
@rodionstolyarov Thank you very much for your first contribution to the project! While I understand that you'd like this feature, it's not something that's been asked for often. Since it adds for configuration options and complicates the generated code. Instead, I'd suggest building this either as a plugin or a separate codegen package that wraps the existing |
Author
|
I see, it's wise not to complicate the code unnecessarily. Thanks for your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlc already have an option to emit the methods with db argument
emit_methods_with_db_argument, but sometimes it is more convenient to keep the current db session in the context. It would be nice if sqlc could extract db from the context itself.To do this, we need to pass a function that knows how to get db form the context to the
Newmethod ofQuerierand then use this function in all the methods generated.This PR adds support for a new option
get_db_from_contextthat implements this feature.