fix: remove default base_url fallback in clients and forward request_options to API requests#220
Open
fern-support wants to merge 2 commits intomasterfrom
Open
fix: remove default base_url fallback in clients and forward request_options to API requests#220fern-support wants to merge 2 commits intomasterfrom
base_url fallback in clients and forward request_options to API requests#220fern-support wants to merge 2 commits intomasterfrom
Conversation
Stop defaulting request base_url to Square::Environment::PRODUCTION in inventory and transfer_orders clients. The Request construction now uses request_options[:base_url] directly (no || fallback), requiring callers or a higher-level config to provide a base_url and avoiding implicit production assumptions. Files changed: lib/square/inventory/client.rb, lib/square/transfer_orders/client.rb.
Add request_options to Square::Internal::JSON::Request calls in lib/square/inventory/client.rb and lib/square/transfer_orders/client.rb so per-request options (e.g. base_url, headers) are properly forwarded. Updated request constructors for various GET/POST/PUT/DELETE endpoints to include request_options and adjusted argument formatting; no other business logic changes.
fern-support
changed the title
fern-support
changed the title
base_url fallback in clients and forward request_options to API requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #218
closes: #219
the reason was these 2 files are added in
.fernigoneso the updates on1.0.0-rc61didn't able to update these files.square-ruby-sdk/.fernignore
Line 15 in c6c3db3
Stop defaulting request base_url to Square::Environment::PRODUCTION in inventory and transfer_orders clients. The Request construction now uses request_options[:base_url] directly (no || fallback), requiring callers or a higher-level config to provide a base_url and avoiding implicit production assumptions. Files changed: lib/square/inventory/client.rb, lib/square/transfer_orders/client.rb.