fix(mce): player nomination handling in voting results #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize sPlayer to 'unconnected' and adjust chat messages to include the nominator's name conditionally.
Updated version number from 1.13.9 to 1.13.10 in mapchooser_extended.inc.
There was a problem hiding this comment.
Pull Request Overview
Fixes a SourceMod exception where Language phrase "7" was not found during vote result announcements. The issue occurred when trying to format chat messages with incorrect parameter counts for translation phrases.
Key changes:
- Initialize player variable to prevent undefined behavior
- Split chat message output to separate general voting results from nominator information
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| addons/sourcemod/scripting/mce/menus.inc | Fixed vote result message formatting by initializing sPlayer variable and separating chat output logic |
| addons/sourcemod/scripting/include/mapchooser_extended.inc | Version bump from 1.13.9 to 1.13.10 |
Comment on lines
+423
to
430
| CPrintToChatAll("{green}[MCE]{default} %t", "Nextmap Voting Finished", map, percent, num_votes); | ||
| if (g_bShowNominator) | ||
| { | ||
| CPrintToChatAll("{green}[MCE]{default} %t - %t %s", "Nextmap Voting Finished", map, percent, num_votes, "Nominated by", sPlayer); | ||
| CPrintToChatAll("{green}[MCE]{default} %t %s", "Nominated by", sPlayer); | ||
| LogAction(-1, -1, "[MCE] Voting for next map has finished. \nNextmap: %s. (Received \"%d\"\%% of %d votes) Nominated by %s", map, percent, num_votes, sPlayer); | ||
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
[nitpick] The chat messages are now split into two separate calls, which may cause them to appear as disconnected messages in chat. Consider combining them into a single message with conditional formatting to maintain message cohesion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize sPlayer to 'unconnected' and adjust chat messages to include the nominator's name conditionally.
Attempt to fix: